Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opening Interactive window breaks editor "sticky scrolling" functionality #157284

Closed
1 of 2 tasks
hookxs opened this issue Aug 5, 2022 · 6 comments
Closed
1 of 2 tasks

Comments

@hookxs
Copy link

hookxs commented Aug 5, 2022

Applies To

  • Notebooks (.ipynb files)
  • Interactive Window and/or Cell Scripts (.py files with #%% markers)

What happened?

In recent VS code there is a "sticky scrolling" feature which can be turned on via "editor.experimental.stickyScroll.enabled": true and it's actually pretty cool:-) However, when Interactive window is opened (and possibly closed, doesn't matter) this feature stops working.

Steps:

  • turn on sticky scrolling
  • start vscode
  • open some python file to check that sticky scrolling works
  • open interactive window (and leave open or close, doesn't matter)
  • go back to your python file and see that now the scrolling is normal as if "sticky" were turned off.

Possibly this might have the same underlying cause as microsoft/vscode-jupyter#10846 since symbols analysis somehow gets messed up?

VS Code Version

Version: 1.70.0 (user setup) Commit: da76f93 Date: 2022-08-04T04:38:16.462Z Electron: 18.3.5 Chromium: 100.0.4896.160 Node.js: 16.13.2 V8: 10.0.139.17-electron.0 OS: Windows_NT x64 10.0.22000

Jupyter Extension Version

v2022.7.1002181843

Jupyter logs

No response

Coding Language and Runtime Version

No response

Language Extension Version (if applicable)

No response

Anaconda Version (if applicable)

No response

Running Jupyter locally or remotely?

No response

@hookxs hookxs added bug Issue identified by VS Code Team member as probable bug triage-needed labels Aug 5, 2022
@rebornix
Copy link
Member

rebornix commented Aug 5, 2022

Not sure how an extension would affect sticky scroll in the core, moving to VS Code for now.

@rebornix rebornix removed the bug Issue identified by VS Code Team member as probable bug label Aug 5, 2022
@rebornix rebornix transferred this issue from microsoft/vscode-jupyter Aug 5, 2022
@rebornix rebornix assigned alexdima and unassigned amunger Aug 5, 2022
@aiday-mar aiday-mar self-assigned this Aug 8, 2022
@alexdima
Copy link
Member

Sticky scroll is just using the DocumentOutlineProvider. @rebornix Do you think the document outline provider might stop working correctly after following these steps?

@rebornix
Copy link
Member

@alexdima that might be the reason, and I'm wondering if the language service stopped working properly once we have interactive window open.

@jrieken
Copy link
Member

jrieken commented Sep 6, 2022

@hookxs Do you still see this?

@hookxs
Copy link
Author

hookxs commented Sep 6, 2022

Hi, no, this has apparently been fixed with one of the latest vs code updates. Also some other related problems were fixed, eg microsoft/vscode-jupyter#10846, so possibly the underlying issue was the same. Thanks:-)

@jrieken
Copy link
Member

jrieken commented Sep 6, 2022

Ok, thanks for catching up

@jrieken jrieken closed this as completed Sep 6, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Oct 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants