Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add display name to diagnostics reported from extensions #155831

Closed
rbairwell opened this issue Jul 21, 2022 · 6 comments
Closed

Add display name to diagnostics reported from extensions #155831

rbairwell opened this issue Jul 21, 2022 · 6 comments
Assignees
Labels
*duplicate Issue identified as a duplicate of another issue(s) feature-request Request for new features or functionality languages-diagnostics Source problems reporting
Milestone

Comments

@rbairwell
Copy link

Could either the "owner"/"source" in "Problems View" have the extension name or product name appended to a "Problems View report" such as:

[VSCode Code] _generated_diagnostic_collection_name_#3"

or

[Ext:ProblematicExtension] _generated_diagnostic_collection_name_#3"

so it is much clearer as to where the problem came from so mis-reports/bugs in the appropriate extensions etc can be reported to the appropriate maintainer.

Being able to right-click on the problem report to "Open/Go to Extension" would be very nice as well.

Reason for requesting

In the "Problems" view the output is:

[{ "resource": "/myresource", "owner": "_generated_diagnostic_collection_name_#3", "severity": 4, "message": "Syntax error: expected \"word\" somewhere in the file", "startLineNumber": 74, "startColumn": 51, "endLineNumber": 74, "endColumn": 51 }]

So I know "_generated_diagnostic_collection_name_#3" was the source/owner of this problem report - but "who" are they? Which extension was it (or was it VS Code its self?) that generated this problem report? It is very unclear.

Platform:
Version: 1.69.2 (user setup)
Commit: 3b889b0
Date: 2022-07-18T16:12:52.460Z
Electron: 18.3.5
Chromium: 100.0.4896.160
Node.js: 16.13.2
V8: 10.0.139.17-electron.0
OS: Windows_NT x64 10.0.19044

@rbairwell rbairwell changed the title Problems view "source/owner" does not give sufficient information as to the source/owner of the problem report Feature Request: Problems view "source/owner" does not give sufficient information as to the source/owner of the problem report Jul 21, 2022
@sandy081 sandy081 assigned jrieken and unassigned sandy081 Jul 25, 2022
@sandy081
Copy link
Member

This is coming from the model

@rbairwell
Copy link
Author

If you mean it is coming from an extension passing a bad model back to VSCode, then yes I agree that is probably the root cause: but it's difficult to tell which extension it is.

Could a feature such as:

If a problem is matched, but no owner is set, then grab the extension name/id (or use tasks.json if the problem matcher was in that) and set the owner to that, but also add an message/debug entry to Output or similar.

be possible to help these issues? (I suspect this may have been done to the Bash IDE extension, but I have definitely seen it with the Shellcheck extension (luckily, that report had an source field so I managed to track down and raise that fault with them )

@jrieken jrieken changed the title Feature Request: Problems view "source/owner" does not give sufficient information as to the source/owner of the problem report Add display name to diagnostics reported from extensions Aug 16, 2022
@jrieken jrieken added feature-request Request for new features or functionality languages-diagnostics Source problems reporting labels Aug 16, 2022
@vscodenpa vscodenpa added this to the Backlog Candidates milestone Aug 16, 2022
@vscodenpa
Copy link

This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our documentation.

Happy Coding!

@vscodenpa
Copy link

This feature request has not yet received the 20 community upvotes it takes to make to our backlog. 10 days to go. To learn more about how we handle feature requests, please see our documentation.

Happy Coding!

@jrieken jrieken modified the milestones: Backlog Candidates, Backlog Oct 6, 2022
@gjsjohnmurray
Copy link
Contributor

/duplicate of #141987

@vscodenpa vscodenpa added the *duplicate Issue identified as a duplicate of another issue(s) label Oct 24, 2022
@vscodenpa
Copy link

Thanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for similar existing issues. See also our issue reporting guidelines.

Happy Coding!

@vscodenpa vscodenpa closed this as not planned Won't fix, can't repro, duplicate, stale Oct 24, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Dec 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*duplicate Issue identified as a duplicate of another issue(s) feature-request Request for new features or functionality languages-diagnostics Source problems reporting
Projects
None yet
Development

No branches or pull requests

5 participants