Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: tasks with shell integration #153365

Closed
3 tasks done
meganrogge opened this issue Jun 27, 2022 · 2 comments
Closed
3 tasks done

Test: tasks with shell integration #153365

meganrogge opened this issue Jun 27, 2022 · 2 comments

Comments

@meganrogge
Copy link
Contributor

meganrogge commented Jun 27, 2022

Refs #150833, #152391, #151769

Authors: @meganrogge @Tyriar

Complexity: 4

Create Issue


Tasks now make use of shell integration sequences to mark points of interest like the first problem found by problem matchers and command runs.

Verify that for:

Finite tasks IE ones that start and stop

  • success / error decorations are shown when the task has a zero / non zero exit code, respectively
  • there's no Rerun command action in the context menu

Watch tasks

  • the first problem in a set of reported problems is marked with a decoration
  • no decoration is shown when there are 0 errors
  • the hover message makes sense to you

Both

  • command navigation using cmd/ctrl + up/down arrow navigates between the points of interest

Generic markers can be added:

  • Run echo -e "\x1b]1337;SetMark\x07" and confirm that there's a generic decoration added
@karthiknadig
Copy link
Member

That went well for me. I had a question about #153600, left a comment there.

@jeanp413
Copy link
Contributor

Is it intended to not be able to disable this? I expect it to respect "terminal.integrated.shellIntegration.enabled" or create another setting. created an issue #153812

@github-actions github-actions bot locked and limited conversation to collaborators Aug 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants