Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow deleting watch entries with a single click #152642

Closed
Tyriar opened this issue Jun 20, 2022 · 4 comments · Fixed by #152861
Closed

Allow deleting watch entries with a single click #152642

Tyriar opened this issue Jun 20, 2022 · 4 comments · Fixed by #152861
Assignees
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues feature-request Request for new features or functionality help wanted Issues identified as good community contribution opportunities insiders-released Patch has been released in VS Code Insiders polish Cleanup and polish issue verification-needed Verification of issue is requested verified Verification succeeded
Milestone

Comments

@Tyriar
Copy link
Member

Tyriar commented Jun 20, 2022

I was an x on watch like there is on breakpoints.

Recording 2022-06-19 at 09 40 34

I notice that devtools has a x button on hover:

image

@connor4312 connor4312 assigned roblourens and unassigned connor4312 Jun 20, 2022
@roblourens roblourens added debug Debug viewlet, configurations, breakpoints, adapter issues polish Cleanup and polish issue help wanted Issues identified as good community contribution opportunities labels Jun 21, 2022
@roblourens roblourens added this to the Backlog milestone Jun 21, 2022
@babakks
Copy link
Contributor

babakks commented Jun 21, 2022

@roblourens I take this if it's okay.

@Tyriar
Copy link
Member Author

Tyriar commented Jun 21, 2022

@babakks should be good to take since it has help wanted, that would be great 👍

@roblourens
Copy link
Member

roblourens commented Jun 21, 2022

I would appreciate a PR, thanks. I think you can copy the way this method override works in the variables tree:

protected override renderActionBar(actionBar: ActionBar, expression: IExpression, data: IExpressionTemplateData) {

to the watch tree renderer:

export class WatchExpressionsRenderer extends AbstractExpressionsRenderer {

The actionbar doesn't show any actions in the variables view by default - the builtin actions only show up in the context menu. Maybe some extension contributes something to that actionbar. But in any case, looks like the AbstractExpressionsRenderer has the ability to render an actionbar already.

@babakks
Copy link
Contributor

babakks commented Jun 22, 2022

@roblourens Thanks for the hint. I've just submitted the PR. Could you please check it?

@roblourens roblourens added the feature-request Request for new features or functionality label Jun 22, 2022
@roblourens roblourens modified the milestones: Backlog, June 2022 Jun 22, 2022
@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jun 22, 2022
@roblourens roblourens added the verification-needed Verification of issue is requested label Jun 28, 2022
@jrieken jrieken added the verified Verification succeeded label Jun 28, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Aug 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues feature-request Request for new features or functionality help wanted Issues identified as good community contribution opportunities insiders-released Patch has been released in VS Code Insiders polish Cleanup and polish issue verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants