-
Notifications
You must be signed in to change notification settings - Fork 30.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removing the textDocumentNotebook API proposal #147414
Comments
Looks like we weren't really using it. I removed our usage. |
Live Share is not using it. I will remove from our package.json. |
Thanks for the ping! We've ticketed this to deal with next week (I'm responding on behalf of @Krzysztof-Cieslak as he's not around today) |
Hey, the use of the API is removed on the Copilot side of things, but the new version of the extension hasn't been released yet. |
@Krzysztof-Cieslak OK can you let me know when it is safe to remove on our side? |
@mjbvz sorry we didn't update sooner: we (Copilot) did a release a few days ago so I think we're good for you to remove it. |
@mjbvz Live Share has not released yet - I will update here once we do. |
Confirmed that dot net is not using this. Will remove them from api consumers |
Live Share released yeserday - you can remove us from the list of consumers. |
The
textDocumentNotebook
api proposal is currently not on track for finalization. See #102091 (comment) for details on thisAs an workaround, today you can achieve the same functionality with:
We plan to remove the
TextDocument.notebook
property once all consumers have moved off of it:If you are on this list, please look into migrating off of this api and let us know if you run into any issues with the migration
The text was updated successfully, but these errors were encountered: