Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Find in files>Replace All option to save and close #14554

Closed
smlombardi opened this issue Oct 26, 2016 · 15 comments
Closed

Feature Request: Find in files>Replace All option to save and close #14554

smlombardi opened this issue Oct 26, 2016 · 15 comments
Assignees
Labels
feature-request Request for new features or functionality search-replace Search and replace issues verification-needed Verification of issue is requested verified Verification succeeded
Milestone

Comments

@smlombardi
Copy link

smlombardi commented Oct 26, 2016

  • VSCode Version: Version 1.7.0-insider
  • OS Version: 10.12.1

Currently when you execute "find in files" and want to replace multiple items in many files, the files all open into the editor. You then need to either save each or "save all", and then close them all.

It would be nice to have an option to do the bulk replace without the files needing to open at all in the workspace, as is possible with Atom and Sublime.

@sandy081 sandy081 added the search Search widget and operation issues label Nov 2, 2016
@sandy081
Copy link
Member

sandy081 commented Nov 2, 2016

@bpasero Is it possible to do bulk edits without opening the files?

@sandy081 sandy081 added this to the Backlog milestone Nov 2, 2016
@bpasero
Copy link
Member

bpasero commented Nov 2, 2016

@sandy081 yeah easy, if you configure auto save delay below 1s, I do not see the files opening. I think if you save after bulk edit quickly enough, the files will not open 👍

@sandy081 sandy081 added the feature-request Request for new features or functionality label Apr 7, 2017
@Skura23
Copy link

Skura23 commented Aug 21, 2017

Nearly a year passed. Seems that this function is still not added, do you have any work around on this by now? @smlombardi

@smlombardi
Copy link
Author

@Skura23 Nope, I've just learned to live with it.

@Skura23
Copy link

Skura23 commented Aug 21, 2017

@smlombardi alright, me too...

@keego
Copy link

keego commented Nov 27, 2017

Any updates? This issue has been quite frustrating to me as it makes refactoring much more time consuming (and nearly impossible in large applications). Changing my auto-save settings to under 1 second as mentioned above still opens all the files, which I have to manually close (user settings have "files.autoSave": "afterDelay" and "files.autoSaveDelay": 500). Not to mention I have to toggle auto save back off for my live-reload flow to continue working.

The most reasonable workaround I've found is to spin up Atom and do a find-and-replace-all through there. It would be really nice for VS Code to have a find-and-replace-all flow similar to the on point user experience Atom provides.

@jjti
Copy link

jjti commented Dec 1, 2017

+1

@sandy081 sandy081 added search-replace Search and replace issues and removed search Search widget and operation issues labels Dec 4, 2017
@boyangwang
Copy link

+1 on this

@gusbemacbe
Copy link

Referring to #22322.

3 months passed...

It is one of the worst experiences I had in VSCode, both stable and insider. I prefer replacing a word in all files and saving all files without opening the files.

Microsoft really failed.

@sandy081 sandy081 modified the milestones: Backlog, February 2018 Feb 2, 2018
@sandy081
Copy link
Member

sandy081 commented Feb 2, 2018

Sorry for not getting on to this due to other priorities.

Will look into this in February.

Thanks.

@sandy081 sandy081 modified the milestones: February 2018, March 2018 Feb 27, 2018
@AlCalzone
Copy link

I just ran into this issue aswell. I want to replace one line in 2800 text files of ~700 KB each (18000 lines). Before anyone asks, these are automatically generated input files for numeric parameter study.

Replace preview works just fine, but when I actually do replace them, it kills VSCode.

@sandy081
Copy link
Member

Replace action will save the file automatically. Because of this, files are not opened while replacing all.

@gusbemacbe
Copy link

@sandy081, I have just updated... but the files still open when replacing one word in all files.

@sandy081
Copy link
Member

@gusbemacbe This will be available from tomorrow's insiders

@gusbemacbe
Copy link

gusbemacbe commented Mar 16, 2018

@smlombardi, @Skura23, @JJTimmons , @boyangwang and all!

Microsoft has just updated the version of VSCode and now you can find and replace one word in all files without opening all the files!!! I tested and it worked!

@sandy081 sandy081 added the verification-needed Verification of issue is requested label Mar 27, 2018
@bpasero bpasero added the verified Verification succeeded label Mar 27, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Apr 28, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality search-replace Search and replace issues verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

9 participants