Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go to implementations won't work when sourcesContent present in *.map #142980

Closed
UchihaYuki opened this issue Feb 14, 2022 · 7 comments
Closed

Go to implementations won't work when sourcesContent present in *.map #142980

UchihaYuki opened this issue Feb 14, 2022 · 7 comments
Assignees
Labels
upstream Issue identified as 'upstream' component related (exists outside of VS Code)

Comments

@UchihaYuki
Copy link

UchihaYuki commented Feb 14, 2022

Does this issue occur when all extensions are disabled?: Yes

  • VS Code Version: 1.64.2
  • OS Version: Windows 10

Reproduce:

When I serve angular app, it will somehow add sourcesContent in my angular libraries' *.map files. Then Go to implementations won't work, even sources is still there. If I reinstall those packages, and right before I run ng serve, it will work again. It will even work, if I just manually delete sourcesContent.

@mjbvz
Copy link
Collaborator

mjbvz commented Feb 14, 2022

Please provide a minimal example project and steps to reproduce this issue

/needsMoreInfo

@UchihaYuki
Copy link
Author

UchihaYuki commented Feb 15, 2022

It seems sourcesContent have higher priority over sources. So when it presents, vs code won't go to the original files. You can add this property to any map file, then Go to Implementation will stop work.
PS: You need to reload vscode to make modification valid between tests.

@mjbvz
Copy link
Collaborator

mjbvz commented Feb 15, 2022

Please share a project that demonstrates this issue so we can investigate it

@UchihaYuki
Copy link
Author

vscode-go-to-implementations

@UchihaYuki
Copy link
Author

In my demo, I use an empty sourcesContent string, but you can use the right string, the result is the same.

@mjbvz
Copy link
Collaborator

mjbvz commented Feb 24, 2022

Ok, that sounds like a duplicate of microsoft/TypeScript#6209 based on your description

Closing as upstream

@mjbvz mjbvz closed this as completed Feb 24, 2022
@mjbvz mjbvz added upstream Issue identified as 'upstream' component related (exists outside of VS Code) and removed info-needed Issue requires more information from poster labels Feb 24, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Apr 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
upstream Issue identified as 'upstream' component related (exists outside of VS Code)
Projects
None yet
Development

No branches or pull requests

3 participants
@mjbvz @UchihaYuki and others