Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support DnD for problem markers and search matches #142508

Closed
sandy081 opened this issue Feb 8, 2022 · 3 comments · Fixed by #142509
Closed

Support DnD for problem markers and search matches #142508

sandy081 opened this issue Feb 8, 2022 · 3 comments · Fixed by #142509
Assignees
Labels
editor-error-widget feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders on-testplan search Search widget and operation issues
Milestone

Comments

@sandy081
Copy link
Member

sandy081 commented Feb 8, 2022

In Problems/Search view, one can DnD a file resource into editor. This request is to support the same functionality for Problem Marker entries and Search match entries.

@sandy081 sandy081 added feature-request Request for new features or functionality search Search widget and operation issues editor-error-widget labels Feb 8, 2022
@sandy081 sandy081 added this to the February 2022 milestone Feb 8, 2022
@sandy081 sandy081 self-assigned this Feb 8, 2022
@sandy081
Copy link
Member Author

sandy081 commented Feb 8, 2022

To support range selection in URI, extended URI fragment selection syntax to support ranges. Eg:

file:///some/file.js#73,84-83,52
file:///some/file.js#L73,84-L83,52

@sandy081
Copy link
Member Author

sandy081 commented Feb 9, 2022

CC @roblourens - Search matches also support this behavior now.

@roblourens
Copy link
Member

Thanks!

@github-actions github-actions bot locked and limited conversation to collaborators Mar 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
editor-error-widget feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders on-testplan search Search widget and operation issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants
@roblourens @sandy081 and others