Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text is super blurry now #13527

Closed
JoeUX opened this issue Oct 11, 2016 · 11 comments
Closed

Text is super blurry now #13527

JoeUX opened this issue Oct 11, 2016 · 11 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug install-update VS Code installation and upgrade system issues upstream Issue identified as 'upstream' component related (exists outside of VS Code) verified Verification succeeded windows VS Code on Windows issues
Milestone

Comments

@JoeUX
Copy link

JoeUX commented Oct 11, 2016

  • VSCode Version: Code 1.6.0 (e52fb0b, 2016-10-10T18:37:40.189Z)
  • OS Version: Windows_NT ia32 10.0.14393
  • Extensions: abusaidm.html-snippets-0.0.16, cssho.vscode-svgviewer-1.2.0, dbaeumer.vscode-eslint-1.0.7, donjayamanne.python-0.4.0, DotJoshJohnson.xml-1.6.0, hnw.vscode-auto-open-markdown-preview-0.0.3, HookyQR.beautify-0.4.0, Ionide.Ionide-fsharp-2.6.9, lukehoban.Go-0.6.43, mohsen1.prettify-json-0.0.3, ms-vscode.cpptools-0.9.2, ms-vscode.csharp-1.4.1

Steps to Reproduce:

  1. Update to 1.6
  2. Reopen

Text has never been as crisp as Sublime, but now it's super blurry, from the menus on top to text in the workspace. At some point, you really ought to show some MS-pride and use DirectWrite since it's your tech and it's how Sublime achieves the crispest text of all editors. Something specific broke in 1.6, but I'm just mentioning DirectWrite as a long-term play.

Display is 1080p 24" with Skylake HD 530 graphics. This model: http://www.dell.com/support/home/us/en/19/product-support/servicetag/F111B22/diagnose

@bgashler1
Copy link
Contributor

bgashler1 commented Oct 11, 2016

Can you take a side-by-side screenshot of Sublime and VS Code?

Do you have ClearType enabled? To check go to Start menu and type in "cttune". Click on
screen shot 2016-10-11 at 11 06 19 am
In the window that opens, see if the box is checked to enable it.

@JoeUX
Copy link
Author

JoeUX commented Oct 11, 2016

Sure, see attached. ClearType is enabled. Note that while the difference is pretty dramatic in the screenshot, it's even bigger in reality – Sublime is slightly fuzzy in the screenshot because it's not the active window.

2016-10-11_13-10-50

@bgashler1 bgashler1 added the windows VS Code on Windows issues label Oct 11, 2016
@bgashler1
Copy link
Contributor

This is very unusual. Thanks for sharing. It's affecting your icons, too. It seems be either a Chromium or Electron bug. Forwarding to @bpasero to see what he thinks.

@bgashler1 bgashler1 added install-update VS Code installation and upgrade system issues electron-update bug Issue identified by VS Code Team member as probable bug labels Oct 11, 2016
@JoeUX
Copy link
Author

JoeUX commented Oct 11, 2016

FWIW, I see similar blurring in Opera and Brave on this machine. (Brave is Brendan Eich's new browser, also based on Chromium.) It's much less of a problem on my Ivy Bridge laptop (Intel HD 4000 GPU), for all three applications. There might be an issue with Chromium and the Skylake GPUs (though I see no blurring in Chrome itself.)

@bpasero bpasero added the upstream Issue identified as 'upstream' component related (exists outside of VS Code) label Oct 13, 2016
@bpasero
Copy link
Member

bpasero commented Oct 13, 2016

likely nothing we can fix on our end up rely on electron to pick up a newer chrome. I encourage you to file bugs against other electron apps to get more attention.

@bpasero bpasero added this to the Backlog milestone Oct 13, 2016
@JoeUX
Copy link
Author

JoeUX commented Oct 24, 2016

Bummer. Note that I filed a Brave bug on this back in August: brave/browser-laptop#3556

The difference is that this has always been an issue with Brave, but only just now became an issue with VS Code 1.6.

Possible clue on reddit, where a poster attributes the same issue on Atom to the use of translate3d: https://www.reddit.com/r/webdev/comments/4dl0pg/i_love_atom/d6y4xmx/

It turns out Atom is blurry on this machine too, though not as blurry as VS Code 1.6. It puzzles me that there would be so much variance in the degree of blurriness across affected Electron clients. It also puzzles me that Chrome itself is never blurry, but all these Chromium projects are, so whatever Google does for Chrome makes a difference. Actually, this might be because they use DirectWrite – they implemented it a couple of years ago.

In any case, a web platform is suboptimal for a text editor, or any desktop/workstation software. Too late for that kind of architectural couch quarterbacking, I know, but maybe something can be done with 2.0 or 3.0. UltraEdit is blazing fast, even faster than Sublime, because it uses bread-and-butter C++ APIs, not shoehorned browser engines. And the UWP version of OneNote is stunningly fast and crisp. VS Code is pretty awesome, and was non-blurry before 1.6, so I hope the team can iron this one out. I love the new UI features, extension manager, etc.

@bpasero
Copy link
Member

bpasero commented Nov 11, 2016

@JoeArizona I am playing around with a newer version of Electron and was wondering if you could give this build a try that includes it to see if something has changed with this issue: https://az764295.vo.msecnd.net/insider/d47c8ba23ff35913052db316aaeef1bb92b0dd99/VSCode-win32-1.8.0-insider.zip

Thanks

@JoeUX
Copy link
Author

JoeUX commented Nov 14, 2016

Hi @bpasero, it's much less blurry in your new build. Screenshot below:

vs code 1 8 insider blurriness test 3

Note that the screenshot is introducing some blurriness – it's not as blurry as this in real life, and it's much better than before.

@bpasero
Copy link
Member

bpasero commented Nov 14, 2016

Thanks, that is some good news.

@bpasero
Copy link
Member

bpasero commented Nov 14, 2016

@JoeArizona if you agree, can we close this issue? do you expect it to become even better from what it is with the Electron update?

@JoeUX
Copy link
Author

JoeUX commented Nov 16, 2016

Sure, close it. It looks like it's fixed (though I still hope you leverage DirectWrite in the future, which is noticeably clearer...)

@bpasero bpasero closed this as completed Nov 17, 2016
@bpasero bpasero modified the milestones: November 2016, Backlog Nov 17, 2016
@mousetraps mousetraps added the verified Verification succeeded label Dec 8, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug install-update VS Code installation and upgrade system issues upstream Issue identified as 'upstream' component related (exists outside of VS Code) verified Verification succeeded windows VS Code on Windows issues
Projects
None yet
Development

No branches or pull requests

4 participants