Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add setting for enabling breakpoints per language #13507

Closed
weinand opened this issue Oct 11, 2016 · 5 comments
Closed

add setting for enabling breakpoints per language #13507

weinand opened this issue Oct 11, 2016 · 5 comments
Assignees
@isidorn
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded
Milestone
October 2016

Comments

@weinand
Copy link
Contributor

weinand commented Oct 11, 2016 •
edited
Loading

With support for languages that are transpiled to JavaScript, an end user needs a quick and simple way to enable breakpoints for new languages (without having to wait for a new extension to appear).

Since a new 'language' cannot be easily introduced as a user or workspace setting, I suggest to implement a pragmatic solution proposed by @isidorn: a setting debugger.allowBreakpointsEverywhere for enabling breakpoints for all (text) files.
@weinand weinand added feature-request Request for new features or functionality debug Debug viewlet, configurations, breakpoints, adapter issues labels Oct 11, 2016
@weinand weinand mentioned this issue Oct 11, 2016
Closed
@isidorn isidorn added this to the October 2016 milestone Oct 11, 2016
@isidorn
Copy link
Contributor

isidorn commented Oct 11, 2016

So we would go with debugger. not debug.?

@weinand
Copy link
Contributor Author

weinand commented Oct 11, 2016

Yes, to keep it aligned with editor (which is not using edit). But I don't have strong opinions.
Let's get @egamma's opinion on this...

@isidorn
Copy link
Contributor

isidorn commented Oct 12, 2016

I vote for debug. because we do not use debugger. anywhere else in the UI, while debug is used everywhere. Also it is shorter

screen shot 2016-10-12 at 10 20 47

@egamma
Copy link
Member

egamma commented Oct 12, 2016

No strong opinion as long as we are consistent.

Keeping Debug is fine by me, I could argue that this would be what we show as the menu name in the menu bar.

@weinand
Copy link
Contributor Author

weinand commented Oct 12, 2016

ok, let's go with 'debug' then.

@isidorn isidorn added the verification-needed Verification of issue is requested label Oct 14, 2016
@octref octref added the verified Verification succeeded label Oct 26, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@isidorn isidorn

Labels
debug Debug viewlet, configurations, breakpoints, adapter issues feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
October 2016
Development

No branches or pull requests
4 participants
@egamma @weinand @isidorn @octref