Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Idea for a standard way of importing Windows Trusted Root Certs for NodeJS #131804

Closed
ryank425 opened this issue Aug 27, 2021 · 3 comments
Closed
Assignees
Labels
*out-of-scope Posted issue is not in scope of VS Code

Comments

@ryank425
Copy link

Background:

I was researching as to how to make our Electron app to fetch Trusted Root Certificates from Windows as it is not possible to know every trusted certificates from clients computer beforehand, and it seems to be that every Electron app uses different ways to solve this issue.

For vscode, I see that this is using
https://github.com/microsoft/vscode-windows-ca-certs from https://github.com/microsoft/vscode/blob/main/package.json (vscode-proxy-agent has dep to vscode-windows-ca-certs)
and it is a fork from
https://github.com/ukoloff/win-ca/

and I do see that This branch is 11 commits ahead, 269 commits behind ukoloff:master. from https://github.com/microsoft/vscode-windows-ca-certs

Since I couldn't make new issues on https://github.com/microsoft/vscode-windows-ca-certs, I was wondering if I can ask this to Microsoft as I know MS itself has other electron apps like MS Teams.

Maybe other Electron apps in MS is using other ways to import Trusted Root Certificates?

@chrmarti
Copy link
Collaborator

I like the idea, unfortunately it's currently beyond the scope of the VS Code project. /cc @deepak1556 in case we have someone familiar with Windows APIs and Node.js internally to pass this on.

@chrmarti chrmarti added the under-discussion Issue is under discussion for relevance, priority, approach label Aug 30, 2021
@deepak1556
Copy link
Collaborator

I am not aware of contacts who can prioritize this one, best way forward is to work with the Node.js community nodejs/node#3159 (comment).

@chrmarti
Copy link
Collaborator

chrmarti commented Sep 9, 2021

Closing as out of scope. Thanks.

@chrmarti chrmarti closed this as completed Sep 9, 2021
@chrmarti chrmarti added *out-of-scope Posted issue is not in scope of VS Code and removed under-discussion Issue is under discussion for relevance, priority, approach labels Sep 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
*out-of-scope Posted issue is not in scope of VS Code
Projects
None yet
Development

No branches or pull requests

3 participants