Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Browser integration tests on Mac are timing out #131622

Closed
Tracked by #132596
sandy081 opened this issue Aug 25, 2021 · 4 comments · Fixed by #134300
Closed
Tracked by #132596

Browser integration tests on Mac are timing out #131622

sandy081 opened this issue Aug 25, 2021 · 4 comments · Fixed by #134300
Assignees
Labels
insiders-released Patch has been released in VS Code Insiders integration-test-failure

Comments

@sandy081
Copy link
Member Author

sandy081 commented Aug 25, 2021

I can confirm that tests started timing out after this commit - e880f7e.
https://dev.azure.com/monacotools/Monaco/_build/results?buildId=132394&view=logs&s=a56e7651-4213-56af-9488-c25fe636c10c

The first commit that is started happening is f0942b3

https://dev.azure.com/monacotools/Monaco/_build/results?buildId=132395&view=logs&s=a56e7651-4213-56af-9488-c25fe636c10c

Checking what commits in between would have caused it.

@mjbvz FYI

@sandy081 sandy081 assigned mjbvz and unassigned TylerLeonhardt and sandy081 Aug 25, 2021
@sandy081
Copy link
Member Author

Assigning to @mjbvz as one of his commits has caused this timeout.

@mjbvz
Copy link
Collaborator

mjbvz commented Sep 28, 2021

Mac seems to be passing pretty reliably now 🤞 but now windows fails consistently on two tests

Been adding a bunch of logging to investigate this. Here's the relevant new error:

__requestfailed__ https://vscode-remote+localhost-003a8000.vscode-resource.vscode-webview.net/d%3A/a/1/s/extensions/vscode-api-tests/testWorkspace/image.png NS_ERROR_UNKNOWN_HOST

The service worker should be intercepting this request so it should never be going to the network at all here. Taking a look to see if I can figure out what is going on

@mjbvz
Copy link
Collaborator

mjbvz commented Sep 30, 2021

Actually it's not windows specific: its Firefox specific. The windows browser tests just happen to be the only ones using Firefox

Can reproduce on Mac too

@github-actions github-actions bot locked and limited conversation to collaborators Nov 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
insiders-released Patch has been released in VS Code Insiders integration-test-failure
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants
@TylerLeonhardt @lszomoru @sandy081 @mjbvz and others