Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can install node-debug2 in old versions of vscode #12843

Closed
roblourens opened this issue Sep 28, 2016 · 5 comments
Closed

Can install node-debug2 in old versions of vscode #12843

roblourens opened this issue Sep 28, 2016 · 5 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug extensions Issues concerning extensions important Issue identified as high-priority verified Verification succeeded

Comments

@roblourens
Copy link
Member

I can install node-debug2 in Code stable 1.5, even though it has a dependency on 1.6.0.

https://github.com/Microsoft/vscode-node-debug2/blob/master/package.json#L46
Exactly the same as node-debug, which shows the correct error message - https://github.com/Microsoft/vscode-node-debug/blob/master/package.json#L24

I can't figure out what the difference is. I also don't know how to debug the gallery service code - I think it runs in a separate process?

@roblourens roblourens added the extensions Issues concerning extensions label Sep 28, 2016
@joaomoreno joaomoreno added bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority labels Sep 28, 2016
@joaomoreno joaomoreno added this to the September 2016 milestone Sep 28, 2016
@joaomoreno
Copy link
Member

This is troublesome. Due to the extension not having a main field in the package.json, the version check doesn't work... Fixed today for future versions... but can't really fix old versions any more. :(

@roblourens
Copy link
Member Author

I published an extension that requires ^1.7.0, and has no 'main', and when I try to install it, I see "Extension not found". If it has a lower engine required, I can install it.

image

Try installing test-extension-pack-1, published by roblourens

@joaomoreno
Copy link
Member

#13062

@joaomoreno
Copy link
Member

Oh... node-debug2 is just like this extension...

@joaomoreno joaomoreno reopened this Sep 30, 2016
@joaomoreno
Copy link
Member

joaomoreno commented Sep 30, 2016

This is what I see when I try to install 99Ztest-extension-pack-1 by roblourens, on a 1.6.0 version.

image

@roblourens roblourens added the verified Verification succeeded label Sep 30, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug extensions Issues concerning extensions important Issue identified as high-priority verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants