Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

files.partcipants.timeout doesn't handle the undefined case #128335

Closed
lramos15 opened this issue Jul 9, 2021 · 0 comments
Closed

files.partcipants.timeout doesn't handle the undefined case #128335

lramos15 opened this issue Jul 9, 2021 · 0 comments
Assignees
Labels
insiders-released Patch has been released in VS Code Insiders unit-test-failure
Milestone

Comments

@lramos15
Copy link
Member

lramos15 commented Jul 9, 2021

As part of my work for #125422 I discovered that const timeout = this.configurationService.getValue<number>('files.participants.timeout'); expects a number but at least in the test cases this value is undefined. Adding the below type safety code leads to many working copy tests failing.

if (typeof timeout !== 'number') {
  return;
}
@lramos15 lramos15 added the bug Issue identified by VS Code Team member as probable bug label Jul 9, 2021
@bpasero bpasero added this to the July 2021 milestone Jul 10, 2021
@bpasero bpasero added unit-test-failure and removed bug Issue identified by VS Code Team member as probable bug labels Jul 10, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Aug 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
insiders-released Patch has been released in VS Code Insiders unit-test-failure
Projects
None yet
Development

No branches or pull requests

3 participants
@bpasero @lramos15 and others