Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show a confirmation notification when installing/uninstalling shell commands #125145

Closed
miguelsolorio opened this issue Jun 1, 2021 · 3 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Milestone

Comments

@miguelsolorio
Copy link
Contributor

Testing #124841

While it's nice that this automatically works in the background, there was no confirmation in the tool that told me whether it succeeded or failed so I had to manually check. It would be nice if there was a toast that confirmed this. Similar to the settings editor that shows this on your first edit:

image

@bpasero
Copy link
Member

bpasero commented Jun 1, 2021

We are actually in the process of removing that notification: #125083

I intentionally didn't want to show a notification, given this decision tree: #119463 (comment)

@bpasero bpasero added the under-discussion Issue is under discussion for relevance, priority, approach label Jun 1, 2021
@miguelsolorio
Copy link
Contributor Author

🤔 Hmm...I guess in the decision tree, Does the user really need to be alerted? you could make an argument for both sides. My issue is I ran an action and I don't know whether it worked or not and have to go check. So my confidence in it working is really low.

@bpasero bpasero added bug Issue identified by VS Code Team member as probable bug and removed under-discussion Issue is under discussion for relevance, priority, approach labels Jun 2, 2021
@bpasero bpasero added this to the May 2021 milestone Jun 2, 2021
@bpasero bpasero closed this as completed in e7b9f3a Jun 2, 2021
@bpasero
Copy link
Member

bpasero commented Jun 2, 2021

I restored the previous message we used to show for both commands but I am using a modal dialog instead of a notification given it originates from a user action.

I think the decision tree should account for this actually, imho being blocked or not should not be the only criteria for deciding on using notifications vs a dialog. I would add that a dialog should be used when triggered by a user action such as a command and a notification is used when something is triggered from the background.

@rzhao271 rzhao271 added the verified Verification succeeded label Jun 3, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Jul 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants
@bpasero @rzhao271 @miguelsolorio and others