Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trust: Can't debug extension right after trusting the folder #122536

Closed
joaomoreno opened this issue Apr 28, 2021 · 10 comments
Closed

Trust: Can't debug extension right after trusting the folder #122536

joaomoreno opened this issue Apr 28, 2021 · 10 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues verified Verification succeeded workspace-trust Trusted workspaces
Milestone

Comments

@joaomoreno
Copy link
Member

joaomoreno commented Apr 28, 2021

Testing #122252

  1. Scaffold a new extension using yo code
  2. Open that extension in VS Code
  3. Choose to trust that folder
  4. Hit F5 to start debugging

🐛 Debug fails to start with the following error:

image

Once the window is reloaded, everything just works.

@isidorn
Copy link
Contributor

isidorn commented Apr 28, 2021

Assigning to April so we investigate into this tomorrow.

@isidorn isidorn added this to the April 2021 milestone Apr 28, 2021
@joaomoreno joaomoreno added bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues labels Apr 29, 2021
@isidorn
Copy link
Contributor

isidorn commented Apr 29, 2021

This just works for me in latest VS Code insiders.
Here are my steps:

  1. VS Code insiders open starter extension sample
  2. Dialog pops up -> you say trust it
  3. Click on start debugging in debug view-> all works

Even if in the dialog I say "do not trust it" and later grant trust via trust editor this works
@JoaMoreno can you repro with todays insiders? Are you doing something different than me?

@isidorn isidorn added info-needed Issue requires more information from poster and removed bug Issue identified by VS Code Team member as probable bug labels Apr 29, 2021
@isidorn isidorn removed this from the April 2021 milestone Apr 29, 2021
@joaomoreno
Copy link
Member Author

I can repro yes. I am in WSL, that might affect it.

@isidorn
Copy link
Contributor

isidorn commented Apr 29, 2021

@sbatten @lszomoru might it be that the Trust does not flow from the remote somehow? Did you get similar issues from other remote users?
Because this feels like the extension JS-debug which is running in the EH is not aware that the user granted trust (probably in the renderer).

@isidorn isidorn reopened this May 7, 2021
@isidorn
Copy link
Contributor

isidorn commented May 7, 2021

Friendly ping @sbatten @lszomoru

@isidorn isidorn removed the info-needed Issue requires more information from poster label May 7, 2021
@lszomoru
Copy link
Member

@isidorn, sorry for the delay. I will investigate this issue today.

@lszomoru
Copy link
Member

I had a look and based on my tests this is not specific to WSL. Debugging the issue now and will circle back with my findings.

@lszomoru lszomoru self-assigned this May 13, 2021
@lszomoru lszomoru added workspace-trust Trusted workspaces bug Issue identified by VS Code Team member as probable bug labels May 13, 2021
@lszomoru lszomoru added this to the May 2021 milestone May 13, 2021
@lszomoru
Copy link
Member

This has been fixed, as part of some work that I have done around extension enablement.

@isidorn
Copy link
Contributor

isidorn commented May 14, 2021

@lszomoru thanks a lot!

@connor4312 connor4312 added the verified Verification succeeded label Jun 4, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Jun 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues verified Verification succeeded workspace-trust Trusted workspaces
Projects
None yet
Development

No branches or pull requests

7 participants
@joaomoreno @isidorn @connor4312 @lszomoru @sbatten @sandy081 and others