Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workspace Trust layout needs work #122523

Closed
joaomoreno opened this issue Apr 28, 2021 · 1 comment
Closed

Workspace Trust layout needs work #122523

joaomoreno opened this issue Apr 28, 2021 · 1 comment
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders verified Verification succeeded workspace-trust Trusted workspaces
Milestone

Comments

@joaomoreno
Copy link
Member

joaomoreno commented Apr 28, 2021

Testing #122252

Issues:

  • When the layout is too narrow, the green and red boxes are cropped by the editor itself and its contents are basically unreadable
  • Also in that same scenario, the scrollbar should be completely aligned to the right margin of the editor. Currently there's some padding which feels weird.
  • The scrollbar should also only be visible when the mouse is over the view. It should hide otherwise, like every scrollbar in the workbench.
  • The focus border around the Trusted Folders view feels weird, do we even need it?

image


Should we place the green and red boxes on top of another, if the space gets too constrained?

image

@joaomoreno joaomoreno changed the title Workspace Trust editor needs responsive layout Workspace Trust layout needs work Apr 28, 2021
@lszomoru lszomoru added the workspace-trust Trusted workspaces label Apr 28, 2021
@sbatten sbatten added the bug Issue identified by VS Code Team member as probable bug label Apr 28, 2021
@sbatten sbatten added this to the May 2021 milestone Apr 28, 2021
sbatten added a commit that referenced this issue May 3, 2021
sbatten added a commit that referenced this issue May 3, 2021
@sbatten sbatten closed this as completed in 022483a May 3, 2021
@sbatten
Copy link
Member

sbatten commented May 3, 2021

I think the focus border makes sense so I didn't change that, addressed the rest

@rzhao271 rzhao271 added the verified Verification succeeded label Jun 2, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Jun 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders verified Verification succeeded workspace-trust Trusted workspaces
Projects
None yet
Development

No branches or pull requests

5 participants
@joaomoreno @lszomoru @sbatten @rzhao271 and others