Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test the statusBar/remoteIndicator menu contribution point #122102

Closed
3 tasks done
aeschli opened this issue Apr 24, 2021 · 1 comment
Closed
3 tasks done

Test the statusBar/remoteIndicator menu contribution point #122102

aeschli opened this issue Apr 24, 2021 · 1 comment

Comments

@aeschli
Copy link
Contributor

aeschli commented Apr 24, 2021

Ref #121180

Complexity: 2

Create Issue


The statusBar/remoteIndicator menu contribution point allows to contribute a command to the remote indicator menu

"contributes": {  
    "menus": {
        "statusBar/remoteIndicator": [
        {
          "command": "remote-wsl.newWindow",
          "when": "!remoteName && isWindows",
          "group": "remote_10_wsl_0_local@1"
        }
   }
}

Only menu entries are accepted "group" follows a specific syntax:

  • For commands from remotes: remote_${order}_${remoteName)_${internalGrouping}
  • For commands from virtual file systems: virtualfs_${order}_${fileScheme)_${internalGrouping}

order is a double digit number used to sort entries with the same supergroup (remote, virtualfs)

  • remoteName is first part of the remoteAuthority (wsl, ssh,...)
  • fileScheme is the URI schema of the virtual file system
  • internalGrouping is of free use for each contribution

Examples:
remote_50_wsl_1-open@1
virtualfs_github-fs_9-help@9

  • Test that you can contribute a menu to the remote indicator menu without the need of having 'proposedAPI' enabled
  • Test that a command is only shown in the menu if group follows the syntax described above.
  • Test that if the group has an invalid syntax, command is not shown, but there's a message is logged to the console dev tools.
@dbaeumer
Copy link
Member

Did some additional testing after @RMacfarlane hint in #122524

@github-actions github-actions bot locked and limited conversation to collaborators Jun 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants