Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clear notebook output button showing in TS files #119852

Closed
jrieken opened this issue Mar 25, 2021 · 4 comments
Closed

Clear notebook output button showing in TS files #119852

jrieken opened this issue Mar 25, 2021 · 4 comments
Assignees
@roblourens @rebornix
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders notebook verified Verification succeeded
Milestone
March 2021

Comments

@jrieken
Copy link
Member

jrieken commented Mar 25, 2021

  • todays insiders
  • open a TS file
  • it shows the notebook clear all command

Screenshot 2021-03-25 at 08 30 34
@rebornix rebornix self-assigned this Mar 25, 2021
@rebornix rebornix added bug Issue identified by VS Code Team member as probable bug notebook labels Mar 25, 2021
@rebornix rebornix added this to the March 2021 milestone Mar 25, 2021
@rebornix
Copy link
Member

Once a notebook is opened, the run all button doesn't go away too.

	when: ContextKeyExpr.and(executeNotebookCondition, ContextKeyExpr.or(NOTEBOOK_INTERRUPTIBLE_KERNEL.toNegated(), NOTEBOOK_HAS_RUNNING_CELL.toNegated()))

@jrieken
Copy link
Member Author

jrieken commented Mar 25, 2021

Unrelated-related question: why is the menu contribution not part of the action definition

@rebornix
Copy link
Member

@jrieken 👍 , created #119885

@lramos15 lramos15 added the verified Verification succeeded label Mar 25, 2021
@github-actions github-actions bot locked and limited conversation to collaborators May 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@roblourens roblourens

@rebornix rebornix

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders notebook verified Verification succeeded
Projects
None yet
Milestone
March 2021
Development

No branches or pull requests
5 participants
@roblourens @rebornix @jrieken @lramos15 and others