Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keybindings editor: small visual flash when changing keybinding #119574

Closed
isidorn opened this issue Mar 23, 2021 · 5 comments
Closed

Keybindings editor: small visual flash when changing keybinding #119574

isidorn opened this issue Mar 23, 2021 · 5 comments
Assignees
Labels
info-needed Issue requires more information from poster

Comments

@isidorn
Copy link
Contributor

isidorn commented Mar 23, 2021

Testing #119503

  1. Use the keyboard to navigate the keybindings editor
  2. Press space to trigger the Keyboard Input
  3. Before the Keboard Input is rendered sometimes there is a quick flash of selection change in the table

This does not happen all the time, but I believe it is up to

  1. User just has focus on element (not selection)
  2. Space is pressed, selection is updated to be on the element -> element is dark blue
  3. Input box shows up thus the element looses focus -> element is light blue again thus causing the flash
@isidorn isidorn assigned isidorn and sandy081 and unassigned isidorn Mar 23, 2021
@sandy081
Copy link
Member

@isidorn Cannot see any flash. Probably want to share a gif?

@sandy081 sandy081 added the info-needed Issue requires more information from poster label Mar 24, 2021
@isidorn
Copy link
Contributor Author

isidorn commented Mar 24, 2021

@sandy081 the GIF can not capture it, it is a split of a second.
Just try it multiple times and I think you will see it. I can also demo it to you over teams if that works better.

@sandy081 sandy081 reopened this Mar 31, 2021
@sandy081 sandy081 removed the info-needed Issue requires more information from poster label Mar 31, 2021
@sandy081
Copy link
Member

sandy081 commented Oct 6, 2021

@isidorn Are you still able to repro this?

@sandy081 sandy081 added the info-needed Issue requires more information from poster label Oct 6, 2021
@isidorn
Copy link
Contributor Author

isidorn commented Oct 6, 2021

This is fine now. Closing. Thanks

@isidorn isidorn closed this as completed Oct 6, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Nov 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
info-needed Issue requires more information from poster
Projects
None yet
Development

No branches or pull requests

3 participants
@isidorn @sandy081 and others