Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test new "clear terminal" feature #119462

Closed
3 tasks done
weinand opened this issue Mar 22, 2021 · 0 comments
Closed
3 tasks done

Test new "clear terminal" feature #119462

weinand opened this issue Mar 22, 2021 · 0 comments
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues testplan-item
Milestone

Comments

@weinand
Copy link
Contributor

weinand commented Mar 22, 2021

Refs: #116699

Complexity: 2

Create Issue


In VS Code a debug extension can delegate the launching of "debuggees" back to VS Code by using the DAP runInTerminal request and passing a command that launches the debuggee.

VS Code handles the runInTerminal request by:

  • creating a new integrated terminal and executing the passed command, or
  • if the terminal already exists and the previous command has finished, it executes the passed command in the same terminal,
  • if the terminal already exists and is stilled blocked by a running command, a new terminal is created.

A consequence of this approach is that the previous commands and output will remain visible in the integrated terminal which is confusing for some users.

In this release we've introduced the feature to automatically clear the integrated terminal before starting a new debug session. The feature is controlled by the setting debug.terminal.clearBeforeReusing.

Setup:

  • create a debug configuration for a debug extension that supports to launch debuggees in the integrated terminal (e.g. js-debug and a "console": "integratedTerminal" property).

Verify:

  • that the feature can be controlled via the setting,
  • that the feature works on the assigned platform,
  • that the feature works for different types of shells configured for the integrated terminal.
@weinand weinand added debug Debug viewlet, configurations, breakpoints, adapter issues testplan-item labels Mar 22, 2021
@weinand weinand added this to the March 2021 milestone Mar 22, 2021
@jrieken jrieken removed their assignment Mar 23, 2021
@TylerLeonhardt TylerLeonhardt removed their assignment Mar 23, 2021
@sbatten sbatten removed their assignment Mar 23, 2021
@sbatten sbatten closed this as completed Mar 23, 2021
@github-actions github-actions bot locked and limited conversation to collaborators May 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues testplan-item
Projects
None yet
Development

No branches or pull requests

4 participants