Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explorer: undo file operations in Explorer #111015

Closed
3 tasks done
isidorn opened this issue Nov 20, 2020 · 1 comment
Closed
3 tasks done

Explorer: undo file operations in Explorer #111015

isidorn opened this issue Nov 20, 2020 · 1 comment
Labels
file-explorer Explorer widget issues testplan-item
Milestone

Comments

@isidorn
Copy link
Contributor

isidorn commented Nov 20, 2020

Refs: #9390

Complexity: 4
Authors: @alexdima @jrieken @isidorn
Issues created assign only to @isidorn please

Create Issue


File explorer now supports undoing file operations. For this we changed the underlying service which we use for file operations, so we need to verify older Explorer functionality as well. Open a large repository, open VS Code Explorer and verify:

  • You can rename files
  • You can drag and drop files from within Explorer. You can drag and drop files from outside of VS Code into the Explorer
  • You can copy files and folders
  • You can Move files to Trash and you can permenantly delete them (alt + context menu)
  • You can create new files and folders in the Explorer
  • Optional: connect to remote and verify you can download files via context menu action
  • All of the above operations can be Undone, both via Ctrl/Cmd + Z and Main Menu > Edit > Undo when the focus is in the Explorer.
  • When the focus is in the editor that the Undo and Redo are applied on the Editor. And that the Explorer is Undone only when the focus is on the Explorer
  • Redo works as expected
  • Delete a very large file > 10mb. Try to bring it back. Make sure VS Code does not freeze.
@isidorn
Copy link
Contributor Author

isidorn commented Dec 2, 2020

Thanks for testing!

@meganrogge meganrogge removed their assignment Dec 2, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Jan 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
file-explorer Explorer widget issues testplan-item
Projects
None yet
Development

No branches or pull requests

5 participants