Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test ThemeIcon color API in trees #109453

Closed
3 tasks done
alexr00 opened this issue Oct 27, 2020 · 0 comments
Closed
3 tasks done

Test ThemeIcon color API in trees #109453

alexr00 opened this issue Oct 27, 2020 · 0 comments

Comments

@alexr00
Copy link
Member

alexr00 commented Oct 27, 2020

Refs: #103120

Complexity: 3

Create Issue


We have new API for coloring codicons:

vscode/src/vs/vscode.d.ts

Lines 826 to 827 in 35c3949

constructor(id: string, color?: ThemeColor);
}

Starting with the tree sample, use the new API to try changing icon colors in the tree. For example, try using a ThemeIcon here:

https://github.com/microsoft/vscode-extension-samples/blob/7b9a0a8c4c631e393862c3e767c7be26bb2233b2/tree-view-sample/src/jsonOutline.ts#L125-L126

Things to verify:

  • Verify that the ThemeIcon color works (tree only).
  • Verify that the documentation for the API makes sense.
@alexr00 alexr00 added this to the October 2020 milestone Oct 27, 2020
@jrieken jrieken self-assigned this Oct 27, 2020
@isidorn isidorn self-assigned this Oct 27, 2020
@jrieken jrieken removed their assignment Oct 27, 2020
@jrieken jrieken removed their assignment Oct 27, 2020
@aeschli aeschli removed their assignment Oct 27, 2020
@isidorn isidorn removed their assignment Oct 27, 2020
@isidorn isidorn closed this as completed Oct 27, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Dec 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants