Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: Pinned Editors #107464

Closed
3 tasks done
bpasero opened this issue Sep 25, 2020 · 0 comments
Closed
3 tasks done

Test: Pinned Editors #107464

bpasero opened this issue Sep 25, 2020 · 0 comments

Comments

@bpasero
Copy link
Member

bpasero commented Sep 25, 2020

Refs: #98161

Complexity: 3

Create Issue


Pinned editors changed to address a couple of issues:

  • verify the new setting workbench.editor.pinnedTabSizing works as advertised in all the three modes (compact, shrink, normal) with normal being the default (refs Pinned tabs: add a setting to show more context #98161)
  • verify you see pinned tabs with a pin icon where usually the close button is and you can unpin from there when in mode shrink and normal).
  • verify you see the same pin icon also in "open editors" view
  • verify you cannot close a pinned tab via CtrlCmd+W when it is active, rather the next tab in the group gets active so that another invocation closes that tab (refs: Prevent closing the pinned tab when using Ctrl + W #100738)
  • verify you can bind CtrlCmd+W to the new command workbench.action.closeActivePinnedEditor to even close pinned editors
  • verify you can pin an editor even when you have tabs disabled and it behaves the same (i.e. does not close from close operations). verify you see the pin-icon top right for pinned editors (refs Support pinned tabs when tabs are disabled #100211)
  • verify you can customize and see tab.lastPinnedBorder, a border drawn after the last pinned tab to better distinguish pinned tabs from non-pinned tabs
@bpasero bpasero added this to the September 2020 milestone Sep 25, 2020
@bpasero bpasero changed the title Test: Pinned Tabs Test: Pinned Editors Sep 25, 2020
@lszomoru lszomoru removed their assignment Sep 29, 2020
@aeschli aeschli removed their assignment Sep 29, 2020
@alexdima alexdima removed their assignment Sep 29, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Dec 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants