Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RenameProvider should be able to signal whether a location is valid for a rename #10723

Closed
DanTup opened this issue Aug 19, 2016 · 2 comments
Closed
Assignees
Labels
api *duplicate Issue identified as a duplicate of another issue(s)

Comments

@DanTup
Copy link
Contributor

DanTup commented Aug 19, 2016

Currently a RenameProvider can be instructed to make renames that are not valid, eg.:

import "dart:html";

Here, you can rename on the import which makes no sense. While it's possible for us to return no edits, it's weird to give the user a textbox pre-populated with import.

It would be better if a RenameProvider can be queried to see whether a rename is valid for a given location and Code can then avoid showing the rename box entirely.

@jrieken jrieken added feature-request Request for new features or functionality api labels Aug 22, 2016
@jrieken
Copy link
Member

jrieken commented Aug 22, 2016

fyi @aeschli

@jrieken
Copy link
Member

jrieken commented Aug 25, 2016

closing this as a duplicate of #7340

@jrieken jrieken closed this as completed Aug 25, 2016
@jrieken jrieken added *duplicate Issue identified as a duplicate of another issue(s) and removed feature-request Request for new features or functionality labels Aug 25, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api *duplicate Issue identified as a duplicate of another issue(s)
Projects
None yet
Development

No branches or pull requests

2 participants