Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blank proxy popup window #106468

Closed
chrisrosko opened this issue Sep 11, 2020 · 10 comments
Closed

blank proxy popup window #106468

chrisrosko opened this issue Sep 11, 2020 · 10 comments
Assignees
Labels
info-needed Issue requires more information from poster proxy Issues regarding network proxies

Comments

@chrisrosko
Copy link

chrisrosko commented Sep 11, 2020

When I start VSCode 1.49.0 the proxy authentication window pops up, but is completly blank (see picture below).

  • VSCode Version: 1.49.0 (e790b93 2020-09-10T13:22:08.892Z)
  • OS Version: Windows_NT x64 10.0.17763

The same happens with VSCode-Insiders 1.49.0 f66741d 2020-08-31T05:32:36.938Z

It worked with a privious version:
Version: 1.45.0-insider
Commit: 4f05de8
Date: 2020-04-13T17:53:50.995Z
Electron: 7.2.1
Chrome: 78.0.3904.130
Node.js: 12.8.1
V8: 7.8.279.23-electron.0
OS: Windows_NT x64 10.0.17763

vscode

@chrmarti
Copy link
Collaborator

Could be #106434. Could you check the latest Insiders build (cca20eb from 9/12 or later)?

@chrmarti chrmarti assigned joaomoreno and unassigned chrmarti Sep 14, 2020
@chrmarti chrmarti added the info-needed Issue requires more information from poster label Sep 14, 2020
@chrisrosko
Copy link
Author

Could be #106434. Could you check the latest Insiders build (cca20eb from 9/12 or later)?

Sure.

@chrisrosko
Copy link
Author

Could be #106434. Could you check the latest Insiders build (cca20eb from 9/12 or later)?

I tested cca20eb and the error is still there.

@joaomoreno joaomoreno assigned bpasero and deepak1556 and unassigned joaomoreno Sep 14, 2020
@bpasero
Copy link
Member

bpasero commented Sep 15, 2020

I cannot reproduce with latest insiders:

image

I followed the steps from #106489 (comment) on Windows.

Also, the blank window should not happen as a result of #106434. If you hit #106434 you will see the dialog closing immediately.

Is there any output when you run code-insiders --verbose and follow these steps that you could attach?

@bpasero bpasero added the proxy Issues regarding network proxies label Sep 15, 2020
@chrisrosko
Copy link
Author

verbose.txt

This is the output I get with --verbose.

@bpasero
Copy link
Member

bpasero commented Sep 15, 2020

@zr0395 is that the full output from the command line? I am missing specific output from the windows itself, they should start with something like this: [16237:0915/093259.345021:INFO:CONSOLE(1705)]

The reason I ask is because I wonder if the auth dialog that opens throws an error. To clarify, you never see the controls to type username and password right?

@chrisrosko
Copy link
Author

I will check again, give me a second.

Yes that right.

@chrisrosko
Copy link
Author

okay it looks like I found the error. I was starting vscode from a network drive.
I copied it to my lokal drive and started it and the proxy authentication worked.

Anyways I didn't find the output in the main log you discribed.

@bpasero
Copy link
Member

bpasero commented Sep 15, 2020

@joaomoreno fyi this maybe unrelated and could point to an issue with supporting the auth dialog from network drives. Though checking the code it seems we load the window like other windows and if something was going wrong with how we compute paths it would probably fail for the workbench too.

I added network drive support to #106489

@bpasero bpasero closed this as completed Sep 15, 2020
@bpasero
Copy link
Member

bpasero commented Sep 15, 2020

Hmmmmmm, something that we only seem to be doing for our normal renderers is this, so I wonder if this was always broken:

if (safeProcess.platform === 'win32' && pathName.startsWith('//')) { // specially handle Windows UNC paths

@github-actions github-actions bot locked and limited conversation to collaborators Oct 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
info-needed Issue requires more information from poster proxy Issues regarding network proxies
Projects
None yet
Development

No branches or pull requests

6 participants