Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unused terminal links are leaking objects #106152

Closed
Tyriar opened this issue Sep 5, 2020 · 0 comments · Fixed by #106153
Closed

Unused terminal links are leaking objects #106152

Tyriar opened this issue Sep 5, 2020 · 0 comments · Fixed by #106153
Assignees
@Tyriar
Labels
debt Code quality issues insiders-released Patch has been released in VS Code Insiders terminal General terminal issues that don't fall under another label terminal-links
Milestone
September 2020

Comments

@Tyriar
Copy link
Member

Tyriar commented Sep 5, 2020

Since we don't know when links are no longer cached by xterm.js, we cannot drop the objects.

Upstream part: xtermjs/xterm.js#3073
@Tyriar Tyriar added debt Code quality issues terminal General terminal issues that don't fall under another label terminal-links labels Sep 5, 2020
@Tyriar Tyriar added this to the September 2020 milestone Sep 5, 2020
@Tyriar Tyriar self-assigned this Sep 5, 2020
@Tyriar Tyriar mentioned this issue Sep 5, 2020
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Oct 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
debt Code quality issues insiders-released Patch has been released in VS Code Insiders terminal General terminal issues that don't fall under another label terminal-links
Projects
None yet
Milestone
September 2020
Development

Successfully merging a pull request may close this issue.

Ensure terminal links get disposed with new xterm.js api microsoft/vscode
2 participants
@Tyriar and others