Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase discoverability of Alt-commands on menu buttons #101995

Closed
gjsjohnmurray opened this issue Jul 9, 2020 · 4 comments
Closed

Increase discoverability of Alt-commands on menu buttons #101995

gjsjohnmurray opened this issue Jul 9, 2020 · 4 comments
Assignees
@sbatten
Labels
feature-request Request for new features or functionality menus Menu items and widget issues
Milestone
Backlog

Comments

@gjsjohnmurray
Copy link
Contributor

Issue Type: Feature Request

When contributing to menus we can use the alt property to specify an alternative command that gets run if the Alt key is pressed.

For example the Split Editor button does this, but the feature is not easily discoverable.

I suggest adding a second line to the button tip (title attribute) that displays the text of the alt-command. For example:

image

VS Code version: Code - Insiders 1.47.0-insider (d5e9aa0, 2020-07-08T10:52:52.439Z)
OS version: Windows_NT x64 10.0.18363
@gjsjohnmurray
Copy link
Contributor Author

Another mockup example using a markdown document:

image

In this case the alternate command has a keybinding.

Or using an alternative to the square brackets:

image

@gjsjohnmurray
Copy link
Contributor Author

Another experiment:
image

@sbatten
Copy link
Member

sbatten commented Jul 9, 2020

I like this idea, adding to backlog to explore.

@sbatten sbatten added the feature-request Request for new features or functionality label Jul 9, 2020
@sbatten sbatten added this to the Backlog milestone Jul 9, 2020
@sbatten sbatten added the menus Menu items and widget issues label Jul 9, 2020
@gjsjohnmurray gjsjohnmurray mentioned this issue Jan 26, 2021
Closed
gjsjohnmurray added a commit to gjsjohnmurray/vscode that referenced this issue Feb 9, 2021
@gjsjohnmurray
microsoft#101995 extend tooltip on menu item with 'alt' command
935081b
gjsjohnmurray added a commit to gjsjohnmurray/vscode that referenced this issue Feb 9, 2021
@gjsjohnmurray
do microsoft#101995 extend tooltip of menu item that defines 'alt' co…
a585f2e 
…mmand
@gjsjohnmurray gjsjohnmurray mentioned this issue Feb 9, 2021
Merged
sbatten pushed a commit that referenced this issue Mar 10, 2021
@gjsjohnmurray
#101995 extend tooltip of menu item that defines 'alt' command (#116211)
75da064 
* do #101995 extend tooltip of menu item that defines 'alt' command

* key label is 'Option' on macOS

* use platform-specific representation of altKey

* incorporate PR feedback
aeschli pushed a commit that referenced this issue Mar 10, 2021
@gjsjohnmurray @aeschli
#101995 extend tooltip of menu item that defines 'alt' command (#116211)
f239e60 
* do #101995 extend tooltip of menu item that defines 'alt' command

* key label is 'Option' on macOS

* use platform-specific representation of altKey

* incorporate PR feedback
@gjsjohnmurray
Copy link
Contributor Author

This shipped in 1.55

@github-actions github-actions bot locked and limited conversation to collaborators May 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sbatten sbatten

Labels
feature-request Request for new features or functionality menus Menu items and widget issues
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
2 participants
@sbatten @gjsjohnmurray