Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failing integration test #101911

Closed
jrieken opened this issue Jul 8, 2020 · 1 comment · Fixed by #118252
Closed

Failing integration test #101911

jrieken opened this issue Jul 8, 2020 · 1 comment · Fixed by #118252
Assignees
@Tyriar
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders integration-test-failure verified Verification succeeded
Milestone
March 2021

Comments

@jrieken
Copy link
Member

jrieken commented Jul 8, 2020

see https://dev.azure.com/vscode/VSCode/_build/results?buildId=48130&view=logs&j=2d2b3007-3c5c-5840-9bb0-2b1ea49925f3&t=d494b5db-eef8-5766-984e-01186010c86f
@Tyriar
Copy link
Member

Tyriar commented Jul 8, 2020 

1) vscode API - terminal Terminal window.onDidWriteTerminalData should listen to all future terminal data events:
     Error: Timeout of 60000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves.
      at listOnTimeout (internal/timers.js:531:17)
      at processTimers (internal/timers.js:475:7)

The second failure likely happened only because of the first test failure.

@Tyriar Tyriar added this to the July 2020 milestone Jul 8, 2020
@Tyriar Tyriar modified the milestones: July 2020, Backlog Aug 3, 2020
@bpasero bpasero added the bug Issue identified by VS Code Team member as probable bug label Sep 22, 2020
@joaomoreno joaomoreno modified the milestones: Backlog, January 2021 Jan 7, 2021
@Tyriar Tyriar modified the milestones: January 2021, February 2021 Jan 25, 2021
@Tyriar Tyriar modified the milestones: February 2021, March 2021 Feb 22, 2021
@Tyriar Tyriar mentioned this issue Mar 9, 2021
Merged
@jrieken jrieken added the verified Verification succeeded label Mar 25, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Apr 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders integration-test-failure verified Verification succeeded
Projects
None yet
Milestone
March 2021
Development

Successfully merging a pull request may close this issue.

Consolidate local and remote terminal implementations microsoft/vscode
5 participants
@joaomoreno @bpasero @jrieken @Tyriar and others