Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension Development Host doesn't prompt to save dirty files on close #10027

Closed
DanTup opened this issue Aug 1, 2016 · 3 comments
Closed

Extension Development Host doesn't prompt to save dirty files on close #10027

DanTup opened this issue Aug 1, 2016 · 3 comments
Assignees
Labels
feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded
Milestone

Comments

@DanTup
Copy link
Contributor

DanTup commented Aug 1, 2016

  • VSCode Version: 1.3.1
  • OS Version: Windows 10

I noticed that if I make changes to files inside the extension development copy of Code then close those files (middle click on the tab, or click the X) then I do not get prompted to save; the changes are just discarded.

I've commented out all code in my activate method along with things like grammars in package.json but it still happens. My main Code window does prompt to save performing the same action.

I cloned one of your sample repos and I see the same behaviour running that.

@kieferrm
Copy link
Member

kieferrm commented Aug 2, 2016

This is still the case in 1.4.0 insiders. Not sure whose area that is. Starting with @bpasero.

@bpasero
Copy link
Member

bpasero commented Aug 6, 2016

As designed, e.g. to enable tests to make buffers dirty and shutdown after tests are done.

@bpasero bpasero closed this as completed Aug 6, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
@bpasero bpasero added feature-request Request for new features or functionality verification-needed Verification of issue is requested labels Aug 5, 2019
@bpasero bpasero added this to the August 2019 milestone Aug 5, 2019
@bpasero
Copy link
Member

bpasero commented Aug 5, 2019

Verification: Run an extension development window with --extension-development-confirm-save and close a dirty file. It should prompt you to save.

@isidorn isidorn added the verified Verification succeeded label Aug 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants