Skip to content

Commit

Permalink
Merge pull request #94512 from microsoft/isidorn/quick-pick-input-acc…
Browse files Browse the repository at this point in the history
…essibility

quickInput: Always show input if screen reader attached
  • Loading branch information
isidorn authored Apr 6, 2020
2 parents e8dbc5e + d00cca3 commit f3cc5ba
Showing 1 changed file with 7 additions and 1 deletion.
8 changes: 7 additions & 1 deletion src/vs/base/parts/quickinput/browser/quickInput.ts
Original file line number Diff line number Diff line change
Expand Up @@ -825,7 +825,13 @@ class QuickPick<T extends IQuickPickItem> extends QuickInput implements IQuickPi
if (!this.visible) {
return;
}
const hideInput = !!this._hideInput && this._items.length > 0; // do not allow to hide input without items
let hideInput: boolean;
if (this.ui.isScreenReaderOptimized()) {
// Always show input if screen reader attached https://github.com/microsoft/vscode/issues/94360
hideInput = false;
} else {
hideInput = !!this._hideInput && this._items.length > 0; // do not allow to hide input without items
}
dom.toggleClass(this.ui.container, 'hidden-input', hideInput);
const visibilities: Visibilities = {
title: !!this.title || !!this.step,
Expand Down

0 comments on commit f3cc5ba

Please sign in to comment.