From 8beecf197966c6fe1ee94caf0de98064098933ab Mon Sep 17 00:00:00 2001 From: jeanp413 Date: Tue, 21 Jun 2022 15:16:06 -0500 Subject: [PATCH] Fixes #152785 --- .../contrib/terminal/browser/terminalInstance.ts | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/src/vs/workbench/contrib/terminal/browser/terminalInstance.ts b/src/vs/workbench/contrib/terminal/browser/terminalInstance.ts index 9d4cad3ccfa33..443c221840e03 100644 --- a/src/vs/workbench/contrib/terminal/browser/terminalInstance.ts +++ b/src/vs/workbench/contrib/terminal/browser/terminalInstance.ts @@ -1277,6 +1277,11 @@ export class TerminalInstance extends Disposable implements ITerminalInstance { override dispose(immediate?: boolean): void { + if (this._isDisposed) { + return; + } + this._isDisposed = true; + this._logService.trace(`terminalInstance#dispose (instanceId: ${this.instanceId})`); dispose(this._linkManager); this._linkManager = undefined; @@ -1315,10 +1320,8 @@ export class TerminalInstance extends Disposable implements ITerminalInstance { // hasn't happened yet this._onProcessExit(undefined); - if (!this._isDisposed) { - this._isDisposed = true; - this._onDisposed.fire(this); - } + this._onDisposed.fire(this); + super.dispose(); }