From 1ca765bab789ee0ae9073ab38911f43c9a224120 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Stefan=20L=C3=B6rwald?= <10850250+stefanloerwald@users.noreply.github.com> Date: Wed, 2 Jun 2021 17:38:48 +0200 Subject: [PATCH 1/2] Fixes #125303 This changes the placement of a div with this class from `top: auto` to `top: 0`, which will avoid placing this div vertically below a sibling div. --- src/vs/base/browser/ui/aria/aria.css | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/vs/base/browser/ui/aria/aria.css b/src/vs/base/browser/ui/aria/aria.css index fdcbb34c7d791..af06e896bd532 100644 --- a/src/vs/base/browser/ui/aria/aria.css +++ b/src/vs/base/browser/ui/aria/aria.css @@ -6,4 +6,5 @@ .monaco-aria-container { position: absolute; /* try to hide from window but not from screen readers */ left:-999em; -} \ No newline at end of file + top: 0; /* avoid being placed underneath a sibling element */ +} From 74d24ff55f41edd3744a1c4983a56d0ba5998936 Mon Sep 17 00:00:00 2001 From: Alexandru Dima Date: Wed, 9 Jun 2021 22:37:43 +0200 Subject: [PATCH 2/2] Reduce impact of fix for #125303 to standalone editor only --- src/vs/base/browser/ui/aria/aria.css | 3 +-- src/vs/editor/standalone/browser/standalone-tokens.css | 1 + 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/vs/base/browser/ui/aria/aria.css b/src/vs/base/browser/ui/aria/aria.css index af06e896bd532..fdcbb34c7d791 100644 --- a/src/vs/base/browser/ui/aria/aria.css +++ b/src/vs/base/browser/ui/aria/aria.css @@ -6,5 +6,4 @@ .monaco-aria-container { position: absolute; /* try to hide from window but not from screen readers */ left:-999em; - top: 0; /* avoid being placed underneath a sibling element */ -} +} \ No newline at end of file diff --git a/src/vs/editor/standalone/browser/standalone-tokens.css b/src/vs/editor/standalone/browser/standalone-tokens.css index 5e6bbadb732b5..1933d35edae5b 100644 --- a/src/vs/editor/standalone/browser/standalone-tokens.css +++ b/src/vs/editor/standalone/browser/standalone-tokens.css @@ -26,6 +26,7 @@ /* See https://github.com/microsoft/monaco-editor/issues/2168#issuecomment-780078600 */ .monaco-aria-container { position: absolute !important; + top: 0; /* avoid being placed underneath a sibling element */ height: 1px; width: 1px; margin: -1px;