Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail packaging if a "files" pattern does not include any file #1016

Closed
hediet opened this issue Jul 16, 2024 · 0 comments · Fixed by #1020
Closed

Fail packaging if a "files" pattern does not include any file #1016

hediet opened this issue Jul 16, 2024 · 0 comments · Fixed by #1020
Assignees
Labels
feature-request Request for new features or functionality

Comments

@hediet
Copy link
Member

hediet commented Jul 16, 2024

vsce package should fail here:

{
	"files": [
           "this-file-does-not-exists.txt"
        ]
}

It should also fail here:

{
	"files": [
           "this-folder-is-empty/**/*"
        ]
}

This will prevent countless of bugs that are very easy to run into.
There should be a flag --ignore-empty-files-patterns to disable this check.

@benibenj benibenj self-assigned this Jul 16, 2024
@benibenj benibenj added the feature-request Request for new features or functionality label Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Request for new features or functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants