You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Mar 18, 2024. It is now read-only.
On Windows, "trashing" the terminal window running Tye does not cause Tye to shutdown gracefully. Whereas, on Mac, it does. This seems related to our use of process.kill() when the user trashes the terminal window, where Windows doesn't support the default SIGTERM signal and so just unconditionally kills the process, resulting in orphaned service processes.
Ideally, the user would have a nicer UX for stopping (debugging) Tye, and not need to trash the terminal window to close Tye; there is an open issue in Tye to allow that. Until that happens, we should find a workaround for Windows.
The text was updated successfully, but these errors were encountered:
Consider adding ability for commandTaskProvider-derived types to specify whether to use a non-standard kill() signal (e.g. SIGTERM is the default but, for tye run on Windows, use SIGINT instead as that should be supported and should be the equivalent of Ctrl+C).
So neither SIGINT nor SIGBREAK are supported as well, making it nigh impossible to signal the process (at the process level) to shutdown gracefully. As a mitigation, one case use taskkill /pid <pid> /f /t to at least help ensure that any sub-processes are killed (which help in the Tye case).
This is more evidence for a non-process-level means to shutdown a Tye application (such as via a control plane).
On Windows, "trashing" the terminal window running Tye does not cause Tye to shutdown gracefully. Whereas, on Mac, it does. This seems related to our use of
process.kill()
when the user trashes the terminal window, where Windows doesn't support the defaultSIGTERM
signal and so just unconditionally kills the process, resulting in orphaned service processes.Ideally, the user would have a nicer UX for stopping (debugging) Tye, and not need to trash the terminal window to close Tye; there is an open issue in Tye to allow that. Until that happens, we should find a workaround for Windows.
The text was updated successfully, but these errors were encountered: