Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow devcontainers to work with Finch #9162

Closed
kidbrax opened this issue Nov 2, 2023 · 5 comments
Closed

allow devcontainers to work with Finch #9162

kidbrax opened this issue Nov 2, 2023 · 5 comments
Assignees
Labels
containers Issue in vscode-remote containers feature-request Request for new features or functionality info-needed Issue requires more information from poster
Milestone

Comments

@kidbrax
Copy link

kidbrax commented Nov 2, 2023

Allow devcontainers to replace Docker with Finch.

Or more specifically, for now the issue seems to be the way vscode gets the docker version. It currently uses 'version --format {{.Server.APIVersion}}'. That command format is not available in Finch. If we could alter the specific command it uses to get the version, Finch "might" work

@github-actions github-actions bot added the containers Issue in vscode-remote containers label Nov 2, 2023
@chrmarti
Copy link
Contributor

chrmarti commented Dec 8, 2023

Related: #6014

@chrmarti chrmarti added the feature-request Request for new features or functionality label Dec 8, 2023
@chrmarti chrmarti added this to the Backlog milestone Dec 8, 2023
@weikequ
Copy link

weikequ commented Jan 3, 2024

I did some investigation here by altering & recompiling finch to output a APIVersion, but in the end, it seems like we might be blocked by the docker socket requirement. See issue linked above.

@benbridts
Copy link

benbridts commented Nov 25, 2024

this is now supported on the finch side: https://runfinch.com/docs/integrations/devcontainers-on-finch/

@chrmarti
Copy link
Contributor

@benbridts Great, thanks!

I guess this issue can be closed then?

@chrmarti chrmarti added the info-needed Issue requires more information from poster label Dec 13, 2024
Copy link

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.

Happy Coding!

@vs-code-engineering vs-code-engineering bot closed this as not planned Won't fix, can't repro, duplicate, stale Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
containers Issue in vscode-remote containers feature-request Request for new features or functionality info-needed Issue requires more information from poster
Projects
None yet
Development

No branches or pull requests

4 participants