Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ssh-agent/gpg-agent/git credentials forward from Windows when using WSL path #5610

Closed
chrmarti opened this issue Sep 20, 2021 · 1 comment
Assignees
Labels
containers Issue in vscode-remote containers *duplicate Issue identified as a duplicate of another issue(s)

Comments

@chrmarti
Copy link
Contributor

Just out of curiosity. I do a slightly different approach. I have a devcontainers recipe which provides a volume for the project.
In it, I clone the project from git.

This way I keep my ssh, git and pgp things in windows, and all are forwarded to the devcontainer nicely (ssh-agent service enabled).

But when running from WSL2 filesystem, VSCode is using ssh, git and pgp from the distro the devcontainers folder is hosted in.

I find it a bit annoying, not to have an option to tell VSCode to always use my gitconfig, ssh config, know_hosts and agent, and pgp from Windows, like it does for devcontainers folder hosted on windows fs.

For everybody having all setup in Windows, I think it would do a huge help to have that switch, as the official docs already provide perfect guidance how to prepare your windows host for devcontainers. It simply breaks the minute u have the folder in wsl2...

Can you postpone and work on using also ssh, git and pgp from wsl2 after u allow people that completed all settings according to the current official docs to benefit of this automation from both windows fs and wsl fs?

Originally posted by @madalinignisca in #3902 (comment)

@chrmarti chrmarti self-assigned this Sep 20, 2021
@chrmarti chrmarti added containers Issue in vscode-remote containers feature-request Request for new features or functionality labels Sep 20, 2021
@chrmarti chrmarti added this to the Backlog milestone Sep 20, 2021
@chrmarti
Copy link
Contributor Author

chrmarti commented Jan 3, 2022

We now first check if we can forward to WSL and if not, try to forward to Windows. Similarly when connected through an SSH server. This was implemented as part of #2994.

@chrmarti chrmarti closed this as completed Jan 3, 2022
@chrmarti chrmarti removed the feature-request Request for new features or functionality label Jan 3, 2022
@chrmarti chrmarti removed this from the Backlog milestone Jan 3, 2022
@chrmarti chrmarti added the *duplicate Issue identified as a duplicate of another issue(s) label Jan 3, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Feb 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
containers Issue in vscode-remote containers *duplicate Issue identified as a duplicate of another issue(s)
Projects
None yet
Development

No branches or pull requests

1 participant