Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate whether we should automatically forward ports based on output #3235

Closed
alexr00 opened this issue Jun 22, 2020 · 4 comments
Closed
Assignees
Labels
feature-request Request for new features or functionality remote-explorer verification-needed Verification of issue is requested verified Verification succeeded
Milestone

Comments

@alexr00
Copy link
Member

alexr00 commented Jun 22, 2020

We can scrape the terminal or other output for things that look like ports to be forwarded. Other extensions do this already, so it might be worth moving to the core.

@alexr00 alexr00 added this to the June 2020 milestone Jun 22, 2020
@alexr00 alexr00 self-assigned this Jun 22, 2020
@alexr00 alexr00 modified the milestones: June 2020, July 2020 Jul 1, 2020
@gyzerok
Copy link

gyzerok commented Jul 14, 2020

It is great, that you are sharing the work you are doing on GitHub. Personally I very much like following iteration plans for VSCode and Remote Extensions. Thank you!

Would it be possible to give a bit more details in the issues? Sometimes issues seem to make sense for you internally, but I feel that they don't make as much sense for a outsider, which a little bit cuts the whole initiative of you being open with the plans.

@alexr00
Copy link
Member Author

alexr00 commented Jul 14, 2020

Updated the description!

@alexr00 alexr00 added the feature-request Request for new features or functionality label Aug 3, 2020
@alexr00 alexr00 modified the milestones: July 2020, August 2020 Aug 3, 2020
@alexr00
Copy link
Member Author

alexr00 commented Aug 31, 2020

To verify, connect to your favorite remote (SSH or containers, not WSL) and run something that causes a host:port (ex: http://localhost:3000/) string to output to the terminal (cloning https://github.com/chrisdias/myUsefulSite works). Open the Remote Explorer Ports view and verify that the port now shows as forwarded. Verify that you can connect to it locally.

@alexr00 alexr00 added the verification-needed Verification of issue is requested label Aug 31, 2020
@weinand
Copy link

weinand commented Sep 2, 2020

Works nicely:

2020-09-02_15-47-50 (1)

What I don't understand is the "Not Forwarding" section:

2020-09-02_15-56-41

Does this mean that a corresponding IP6 address isn't forwarded?

Two (small) issues:

  • Port scraping doesn't work with debug console:
    2020-09-02_16-00-04
  • The set of port-patterns and the fact that they must be URLs is not obvious: it would be helpful to have this list somehow available in the "Forwarded Ports" view.

@weinand weinand added the verified Verification succeeded label Sep 2, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Sep 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality remote-explorer verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants