Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple container config #2143

Closed
davidtvs opened this issue Jan 9, 2020 · 6 comments
Closed

Multiple container config #2143

davidtvs opened this issue Jan 9, 2020 · 6 comments
Labels
containers Issue in vscode-remote containers feature-request Request for new features or functionality

Comments

@davidtvs
Copy link

davidtvs commented Jan 9, 2020

I have two suggestions based on my use-case:

  1. Running a command after the container is created is possible with postCreateCommand, it would be nice to have a preCreateCommand to run commands before the container is created.
  2. Support multiple configurations in devcontainer.json and allow the user to pick which one to run. Similar to the request in OS specific dev containers #2067 but I think it should more generic instead of OS-specific only.

If I missed something and there are solutions to these problems (or workarounds) please share.

@chrmarti
Copy link
Contributor

chrmarti commented Feb 4, 2020

preCreateCommand is tracked with #1045. Let's track the multiple configs here. (It's best to file individual feature requests in separate issues.)

@chrmarti chrmarti changed the title Pre-command and multiple container config Multiple container config Feb 4, 2020
@chrmarti chrmarti added containers Issue in vscode-remote containers feature-request Request for new features or functionality labels Feb 4, 2020
@chrmarti chrmarti removed their assignment Feb 4, 2020
@ahoenig1
Copy link

Supporting multiple devcontainers would be HUGE. When multiple definitions are found, selecting re-open in container should then prompt you to pick one of the container definitions. This would help with developing/testing/debugging code on different versions of linux (not all products are deployed in docker). If a docker.host field can also be added to the config, it would also be great for developing code for embedded platforms like a tegra. The code can be developed on a desktop, and then you can switch to the aarch64 container and run it in that container over SSH on the actual hardware. Currently to do that you need to replace your devcontainer and enter the IP in settings.json.

@bhack
Copy link

bhack commented Mar 17, 2020

A frequent use case for multiple containers Is generally GPU/CPU separate images.

@bamurtaugh
Copy link
Member

Thanks for opening this thread! It appears to be along the lines of #1165. While 1165 focuses on different versions of Python in its explanation, I think the overarching point still stands: being able to choose a certain container config from a set of possible configurations when opening your code in a container.

I think it'd make sense to migrate to that thread to consolidate our discussion- if that grouping sounds alright with folks in this thread too, I'll go ahead and close this issue to avoid dupes.

@bhack
Copy link

bhack commented Oct 21, 2020

@bamurtaugh Ok can you summarize this thread there?

@bamurtaugh
Copy link
Member

@bhack Yes, I'm happy to summarize this thread in #1165! I'll do so now and then close out this issue. Please let me know if you have any other feedback or questions, and also feel free to reply in that thread as well.

@github-actions github-actions bot locked and limited conversation to collaborators Dec 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
containers Issue in vscode-remote containers feature-request Request for new features or functionality
Projects
None yet
Development

No branches or pull requests

5 participants