Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Build Args during Docker Build #1857

Closed
eedwards-sk opened this issue Nov 16, 2019 · 1 comment
Closed

Support Build Args during Docker Build #1857

eedwards-sk opened this issue Nov 16, 2019 · 1 comment

Comments

@eedwards-sk
Copy link

I seem to be unable to specify build args during the dev container build process.

https://docs.docker.com/engine/reference/commandline/build/#set-build-time-variables---build-arg

I want to perform an npm install during the build process, but this requires providing an environment variable for npm private registry authentication.

a build arg would be the way to accomplish this (an env var)

I would like a way to provide build args during the build process, from file (so e.g. an .env file), e.g. "build_arg_file": "npmjs.env", :

{
	"name": "foo",
	"context": "..",
	"dockerFile": "Dockerfile",
	"build_arg_file": "npmjs.env",    
	"settings": { 
		"terminal.integrated.shell.linux": "/bin/bash"
	},
	"extensions": [
		"dbaeumer.vscode-eslint"
	]
}
@Chuxel Chuxel transferred this issue from microsoft/vscode-dev-containers Nov 16, 2019
@Chuxel
Copy link
Member

Chuxel commented Nov 16, 2019

I believe this is a dupe of #46. Lets continue chatting as needed over there. Would be great if you would upvote as well!

@Chuxel Chuxel closed this as completed Nov 16, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Dec 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants