-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Share Git user.name and user.email to containers #1729
Comments
If you use a devcontainer.json we already copy the user's |
Problem is that if you set it globally it doesn't seem to pass the environment variables or anything to the containers. If you set them locally to the repo then it works fine. |
Could you elaborate? Which environment variables? By 'globally' you mean the user's .gitconfig? |
git config --global user.email "[email protected]" These should be passed into the container somehow so that they work if they're not set in the local project. |
Does that store it in your home folder's |
Don't know. But it's the default in VS.net (full fat) |
Please check what's in your |
Yup. That's where it's set. |
@JohnGalt1717 Could you give VS Code Insiders a try? The Remote-Containers extension comes in a slightly newer version with fixes in that area for that. See: https://code.visualstudio.com/insiders/ |
Appeared to work. Thanks! |
Every time we rebuild a container we have to reset these options.
It would be really nice if vs code would pick up the .git local project settings for this and if that isn't set, pick up the ones from global and pass them in as the appropriate environment variables.
The text was updated successfully, but these errors were encountered: