Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test UI update and deprecations #16769

Merged
merged 39 commits into from
Aug 5, 2021
Merged

Conversation

karthiknadig
Copy link
Member

@karthiknadig karthiknadig commented Jul 23, 2021

Things in this PR:

  1. Switch extension to use the new Test UI API.
  2. Removes all the old commands for testing in favor of commands from VS Code.
  3. Removes support for Nose test framework.
  4. Removes dependency of tests on language server.

Closes #15750 Using new Test UI from VS code:
image

Closes #10898 Uses VS Code API for over code lenses
image

Closes #16371 Remove nose test support.

Closes #1654
Closes #2382
Closes #2644
Closes #2660
Closes #2790
Closes #3062
Closes #3591
Closes #3652
Closes #4469
Closes #4848
Closes #5347
Closes #5417
Closes #5791
Closes #5889
Closes #6787
Closes #7150
Closes #7443
Closes #7870
Closes #8405
Closes #8448
Closes #8675
Closes #8761
Closes #8836
Closes #9026
Closes #9402
Closes #9640
Closes #9854
Closes #10898
Closes #10972
Closes #11864
Closes #11866
Closes #12043
Closes #12218
Closes #12403
Closes #12995
Closes #13147
Closes #13285
Closes #13713
Closes #13916
Closes #15260
Closes #15736
Closes #16371
Closes #16475

@github-actions github-actions bot requested a review from karrtikr July 23, 2021 05:42
@github-actions github-actions bot requested a review from kimadeline July 23, 2021 05:42
@karthiknadig karthiknadig added the skip package*.json package.json and package-lock.json don't both need updating label Jul 23, 2021
src/client/common/utils/delayTrigger.ts Outdated Show resolved Hide resolved
src/client/testing/main.ts Show resolved Hide resolved
src/client/common/utils/delayTrigger.ts Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
src/client/common/utils/delayTrigger.ts Show resolved Hide resolved
src/client/testing/main.ts Outdated Show resolved Hide resolved
src/client/testing/testController/controller.ts Outdated Show resolved Hide resolved
@karthiknadig karthiknadig force-pushed the new-test-ui branch 2 times, most recently from 1aaa6bf to b1f1ae1 Compare July 28, 2021 19:07
@kimadeline kimadeline mentioned this pull request Jul 29, 2021
@quaesitor-scientiam
Copy link

Has this fix made it into a release? I am experiencing same kind problem mentioned in comments and would like to get it fixed.

Thanks

@karthiknadig
Copy link
Member Author

@quaesitor-scientiam This was in 2021.09 release.

@quaesitor-scientiam
Copy link

Thanks, had a hard time trying to figure that out.

@quaesitor-scientiam
Copy link

quaesitor-scientiam commented Nov 30, 2021

One more question since this is vscode-python how does it relate to VSCode releases? Need to able to management which release of VSCode to get and approve.

@karthiknadig
Copy link
Member Author

@quaesitor-scientiam They are unrelated. But since the extension depends on the features exposed by VS Code, we sometimes require a minimum version. For the latest version of the python extension (v2021.11.*), the minimum VS Code version needed is v1.61.0.

This is set here

"vscode": "^1.61.0"

@quaesitor-scientiam
Copy link

Thanks again for the quick reply

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment