Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Renaming variable adds double line breaks throughout file when using CRLF #24453

Closed
Sprocketer opened this issue Nov 16, 2024 · 3 comments
Closed

Renaming variable adds double line breaks throughout file when using CRLF #24453

Sprocketer opened this issue Nov 16, 2024 · 3 comments
Assignees
@karthiknadig
Labels
info-needed Issue requires more information from poster triage-needed Needs assignment to the proper sub-team

Comments

@Sprocketer
Copy link

Behaviour

Pressing F2 to rename a variable, renaming and pressing enter, and then for some reason double line breaks are added to the entire Python file (so that there is a blank line between literally every line)

Steps to reproduce:

  1. Select variable
  2. Press F2 to rename
  3. Rename

Diagnostic data

Nothing is outputted here
@github-actions github-actions bot added the triage-needed Needs assignment to the proper sub-team label Nov 16, 2024
@Sprocketer
Copy link
Author

Update: found old threads with this, it happens when you use CRLF instead of LF - could this be fixed so that it doesn't happen with CRLF?

@Sprocketer Sprocketer changed the title Renaming variable adds double line breaks throughout file Renaming variable adds double line breaks throughout file when using CRLF Nov 16, 2024
@karthiknadig
Copy link
Member

@Sprocketer Which language server are you using? look for the following setting python.languageServer.

If it is jedi then it is this one pappasam/jedi-language-server#159 . It should be addressed upstream.

@github-actions github-actions bot added the info-needed Issue requires more information from poster label Nov 18, 2024
@karthiknadig karthiknadig self-assigned this Nov 18, 2024
@karthiknadig
Copy link
Member

Closing this since this is likely jedi and should be addressed on the Jedi LS repo: pappasam/jedi-language-server#159

@karthiknadig karthiknadig closed this as not planned Won't fix, can't repro, duplicate, stale Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@karthiknadig karthiknadig

Labels
info-needed Issue requires more information from poster triage-needed Needs assignment to the proper sub-team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@karthiknadig @Sprocketer