Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pressing enter while focused on REPL history will execute the cell #24393

Open
amunger opened this issue Nov 5, 2024 · 4 comments · Fixed by #24394
Open

pressing enter while focused on REPL history will execute the cell #24393

amunger opened this issue Nov 5, 2024 · 4 comments · Fixed by #24394
Assignees
Labels
area-repl bug Issue identified by VS Code Team member as probable bug verification-found Issue verification failed
Milestone

Comments

@amunger
Copy link

amunger commented Nov 5, 2024

Type: Bug

Steps to reproduce:

  1. run Python: start native REPL
  2. run some code from the input box
  3. focus the executed cell in the history and press enter

🐛 cell is executed again

Diagnostic data

Output for Python in the Output panel (ViewOutput, change the drop-down the upper-right of the Output panel to Python)

XXX

Extension version: 2024.19.2024103101
VS Code version: Code - Insiders 1.96.0-insider (f87f8a56f3a30238076bee3db39c245bd69be264, 2024-11-05T05:04:15.310Z)
OS version: Windows_NT arm64 10.0.26100
Modes:

  • Python version (& distribution if applicable, e.g. Anaconda): 3.13.0
  • Type of virtual environment used (e.g. conda, venv, virtualenv, etc.): Venv
  • Value of the python.languageServer setting: Default
User Settings


languageServer: "Pylance"

experiments
• optInto: ["All"]

Installed Extensions
Extension Name Extension Id Version
Azure Account ms-vscode.azure-account 0.12.0
Azure Repos ms-vscode.azure-repos 0.41.2024101602
Azure Resources ms-azuretools.vscode-azureresourcegroups 0.9.8
Bearded Theme BeardedBear.beardedtheme 9.3.0
Bookmarks alefragnani.Bookmarks 13.5.0
Data Analysis for Copilot ms-vscode.vscode-copilot-data-analysis 0.2.2
Data Wrangler ms-toolsai.datawrangler 1.13.1
Deno denoland.vscode-deno 3.42.0
Dev Containers ms-vscode-remote.remote-containers 0.390.0
Docker ms-azuretools.vscode-docker 1.29.3
Draw.io Integration hediet.vscode-drawio 1.6.6
EditorConfig for VS Code EditorConfig.EditorConfig 0.16.4
esbuild Problem Matchers connor4312.esbuild-problem-matchers 0.0.3
ESLint dbaeumer.vscode-eslint 3.0.13
Extension Test Runner ms-vscode.extension-test-runner 0.0.12
Flame Chart Visualizer for JavaScript Profiles ms-vscode.vscode-js-profile-flame 1.0.9
German Language Pack for Visual Studio Code MS-CEINTL.vscode-language-pack-de 1.95.2024103009
Git Blame waderyan.gitblame 11.1.1
GitHub Actions github.vscode-github-actions 0.27.0
GitHub Copilot GitHub.copilot 1.243.1196
GitHub Copilot Chat GitHub.copilot-chat 0.23.2024110101
GitHub Issue Notebooks ms-vscode.vscode-github-issue-notebooks 0.0.130
GitHub Pull Requests GitHub.vscode-pull-request-github 0.101.2024110504
GitHub Repositories GitHub.remotehub 0.64.0
JavaScript Debugger ms-vscode.js-debug 1.95.2
JavaScript Debugger (Nightly) ms-vscode.js-debug-nightly 2024.11.417
JavaScript Debugger Companion Extension ms-vscode.js-debug-companion 1.1.3
JS Debug Value Editor (Experimental) ms-vscode.debug-value-editor 0.1.0
Jupyter ms-toolsai.jupyter 2024.11.2024103101
Jupyter Cell Tags ms-toolsai.vscode-jupyter-cell-tags 0.1.9
Jupyter Keymap ms-toolsai.jupyter-keymap 1.1.2
Jupyter Notebook Renderers ms-toolsai.jupyter-renderers 1.0.2024102901
Jupyter Slide Show ms-toolsai.vscode-jupyter-slideshow 0.1.6
Line Filter roblourens.vscode-line-filter 0.0.3
Luna Paint — Image Editor Tyriar.luna-paint 0.16.0
Markdown Preview Mermaid Support bierner.markdown-mermaid 1.26.0
Mermaid Editor tomoyukim.vscode-mermaid-editor 0.19.1
Mocha Test Explorer hbenl.vscode-mocha-test-adapter 2.14.1
Node.js Notebooks (REPL) donjayamanne.typescript-notebook 2.0.6
PR Pinger jrieken.vscode-pr-pinger 0.0.6
Prettier - Code formatter esbenp.prettier-vscode 11.0.0
Prettify JSON mohsen1.prettify-json 0.0.3
Pylance ms-python.vscode-pylance 2024.11.1
Python ms-python.python 2024.19.2024103101
Python Debugger ms-python.debugpy 2024.13.2024103001
Remote - SSH ms-vscode-remote.remote-ssh 0.116.2024102915
Remote - SSH: Editing Configuration Files ms-vscode-remote.remote-ssh-edit 0.87.0
Remote - Tunnels ms-vscode.remote-server 1.6.2024100809
Remote Explorer ms-vscode.remote-explorer 0.5.2024103109
Remote Repositories ms-vscode.remote-repositories 0.43.2024102201
Ruff charliermarsh.ruff 2024.54.0
SVG Previewer vitaliymaz.vscode-svg-previewer 0.7.0
Table Visualizer for JavaScript Profiles ms-vscode.vscode-js-profile-table 1.0.10
Test Adapter Converter ms-vscode.test-adapter-converter 0.2.1
Test Explorer UI hbenl.vscode-test-explorer 2.22.1
TypeScript + Webpack Problem Matchers amodio.tsl-problem-matcher 0.6.2
vscode-mermAId ms-vscode.copilot-mermaid-diagram 0.0.2024103101
WSL ms-vscode-remote.remote-wsl 0.88.5
YAML redhat.vscode-yaml 1.15.0
System Info
Item Value
CPUs Snapdragon(R) X 12-core X1E80100 @ 3.40 GHz (12 x 2976)
GPU Status 2d_canvas: enabled
canvas_oop_rasterization: enabled_on
direct_rendering_display_compositor: disabled_off_ok
gpu_compositing: enabled
multiple_raster_threads: enabled_on
opengl: enabled_on
rasterization: enabled
raw_draw: disabled_off_ok
skia_graphite: disabled_off
video_decode: enabled
video_encode: enabled
vulkan: disabled_off
webgl: enabled
webgl2: enabled
webgpu: enabled
webnn: unavailable_software
Load (avg) undefined
Memory (System) 31.57GB (5.94GB free)
Process Argv --crash-reporter-id 8dc59ac4-06a1-44f4-bf7a-b9a7c128e443
Screen Reader yes
VM 0%
A/B Experiments
vsliv368:30146709
vspor879:30202332
vspor708:30202333
vspor363:30204092
vscod805cf:30301675
vsaa593cf:30376535
py29gd2263:31024238
c4g48928:30535728
vscrp:30624060
962ge761:30841072
pythongtdpath:30726887
pythonnoceb:30776497
asynctok:30898717
dsvsc014:30777825
dsvsc015:30821418
pythonmypyd1:30859725
h48ei257:31000450
pythontbext0:30879054
cppperfnew:30980852
pythonait:30973460
945dj816:31013170
dvdeprecation:31040973
dwnewjupyter:31046869
impr_priority:31057980
nativerepl1:31134653
refactort:31084545
pythonrstrctxt:31093868
nativeloc1:31118317
cf971741:31144450
e80f6927:31120813
i21gd607:31141543
iacca1:31150324
notype1:31143044
dwcopilot:31158714
g7688163:31155431

@amunger amunger self-assigned this Nov 5, 2024
@amunger amunger added the bug Issue identified by VS Code Team member as probable bug label Nov 5, 2024
@github-actions github-actions bot added the triage-needed Needs assignment to the proper sub-team label Nov 5, 2024
@amunger amunger self-assigned this Nov 5, 2024
@amunger amunger removed the triage-needed Needs assignment to the proper sub-team label Nov 5, 2024
@amunger amunger closed this as completed in b1cb5c2 Nov 5, 2024
@amunger amunger added this to the November 2024 milestone Nov 5, 2024
@anthonykim1 anthonykim1 added the verification-needed Verification of issue is requested label Dec 2, 2024
@anthonykim1
Copy link

anthonykim1 commented Dec 2, 2024

Verification steps:

  1. Install latest pre-release of Python extension
  2. Turn on setting to enable native repl
  3. run some code in REPL
  4. focus on previous "cell" of native repl and press enter
  5. make sure that cell is NOT executed.

@joyceerhl joyceerhl added verification-found Issue verification failed and removed verification-needed Verification of issue is requested labels Dec 3, 2024
@joyceerhl
Copy link

This still repros for me, on 2024.21.2024112901. Also, the kernel indicator continued to spin and the Interrupt button was present and grayed out even though the REPL was already ready for use. Image

@joyceerhl joyceerhl reopened this Dec 3, 2024
@github-actions github-actions bot added the triage-needed Needs assignment to the proper sub-team label Dec 3, 2024
@anthonykim1 anthonykim1 added area-repl and removed triage-needed Needs assignment to the proper sub-team labels Dec 3, 2024
@anthonykim1
Copy link

Thanks @joyceerhl I filed issue here: #24541 (comment) for REPL spinning.
The interrupt button should be colored in when you start running something heavy, but basically stays grayed out if there are nothing to interrupt.

@anthonykim1
Copy link

anthonykim1 commented Dec 3, 2024

@amunger
From what I've tested and what @rzhao271 told me, pressing enter on a focused cell creates a blank cell additionally on top: Image

Behavior seems to be conditionally fine (doesnt create additional cell) when the cell shows triple ... as it just unwinds the cell content but pressing enter again creates a new empty cell or executes empty cell:

Screen.Recording.2024-12-03.at.3.26.16.PM.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-repl bug Issue identified by VS Code Team member as probable bug verification-found Issue verification failed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants