Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Standardize on syntax highlight organization and formatting #233

Closed
brettcannon opened this issue Nov 15, 2017 · 1 comment
Closed

Standardize on syntax highlight organization and formatting #233

brettcannon opened this issue Nov 15, 2017 · 1 comment
Assignees
@brettcannon
Labels
debt Covers everything internal: CI, testing, refactoring of the codebase, etc.

Comments

@brettcannon
Copy link
Member

The language spec for test output lives entirely in syntaxes/ and is specified using the .tmLanguage format. The pip requirements file is spread out between syntaxes/ and languages/ and is defined using the JSON version of the .tmLanguages spec. The pip requirements files should be brought in line by consolidating all of the files into syntaxes/ and moving over to the XML format.
@brettcannon brettcannon added awaiting 2-PR debt Covers everything internal: CI, testing, refactoring of the codebase, etc. labels Nov 15, 2017
@brettcannon brettcannon added this to the December 2017 milestone Nov 15, 2017
@brettcannon brettcannon self-assigned this Nov 15, 2017
@DonJayamanne
Copy link

DonJayamanne commented Nov 15, 2017 •
edited
Loading

@brettcannon the test.tmLanguage is not used, will remove that.
Also, vscode seems to have a mixture of json and xml formats, so I'd be inclined to leave the format as is.

@brettcannon brettcannon removed this from the December 2017 milestone Nov 15, 2017
@lock lock bot locked as resolved and limited conversation to collaborators Jul 12, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@brettcannon brettcannon

Labels
debt Covers everything internal: CI, testing, refactoring of the codebase, etc.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@brettcannon @DonJayamanne