Modify getActiveEnvironmentPath() API when resource is passed as undefined in a multiroot workspace
#21256
Comments
github-actions
bot
added
the
triage-needed
|
If I specify the interpreter the server starts, but then it doesn't use the environment |
|
@rdbisme Please provide logs from Output > Black Formatter. Also, provide path to the environment where you have installed black. |
I have a multiproject workspace, so I have a virtualenvironment selected per project.
|
|
@rdbisme Can you share your |
|
A sanitized version: {
"folders": [
{
"name": "****_prod",
"path": "****/src/****_prod"
},
{
"name": "****",
"path": "****"
},
{
"name": "qp",
"path": "****-deploy/src/qp"
},
{
"name": "****-strats-ci",
"path": "****-strats-ci"
},
{
"name": "xxxy0",
"path": "xxxy0"
},
{
"name": "****-ci",
"path": "****-ci"
},
{
"name": "backfill-ci",
"path": "****-deploy/src/backfill-ci"
},
{
"name": "internal-docs",
"path": "****-deploy/src/internal-docs"
},
{
"path": "****-api"
},
{
"path": "****-monitoring"
},
{
"path": "****-deploy/src/cmd-batch"
},
{
"path": "****-ui"
}
],
"settings": {
"yaml.schemas": {
"https://gitlab.com/gitlab-org/gitlab/-/raw/master/app/assets/javascripts/editor/schema/ci.json": "file:///c%3A/Users/xxxxx/git/****-strats-ci/template-research-ci.yml"
}
},
"launch": {
"version": "0.2.0",
"configurations": [
{
"name": "Python: Debug Tests",
"type": "python",
"request": "launch",
"program": "${file}",
"purpose": ["debug-test"],
"console": "integratedTerminal",
"justMyCode": false,
"env": { "PYTEST_ADDOPTS": "--no-cov -v" }
}
],
"compounds": []
}
}
|
|
@rdbisme Can you share the logs from the python extension? Also, when you select interpreter for your multi root scenario did you select for the entire workspace or per root? |
I selected per root. And Intellisense and completions work as expected. Do you still need the logs? |
|
@rdbisme Can you select one for the entire workspace as well? and see if that helps. Another option is to add the interpreter here, (this is a temporary solution): This is scenario that is not currently handled well. I will need to investigate what we can do to provide a better fix for this in these cases. |
That unfortunately doesn't work because I have different black versions requirements on different roots. |
The root cause if this seems to be same as microsoft/vscode-black-formatter#233 Closing this against that issue. |
|
@karthiknadig are you sure about this? I'm pretty confident this configuration was working before. The problem is that right now it requires an interpreter set up before starting. Also I have explicitly set up It stopped working very recently. |
|
I see. When you say recently was it in the last week? If it is last week, it could be due to python extension. You could revert python extension to 2023.6.1 and see if it helps. |
|
You can also try selecting a python version for this level: It need not be the python that you use for the workspace, we just need one to run the server. |
|
If none of that works, would it be possible for you to create a minimal repro with details on how and where you have environments. That will greatly help debug this. I tried creating a few different styles of multi-root repositories, I was not able to repro it. |
|
I have no environments, just the system-level Python, with Black installed with Windows 10 Python is installed for all users, it's in The notebooks work just fine with this Python interpreter. No environments. No workspace. I just start VSCode, open a folder, then open a Jupyter Notebook in that folder. I cannot format the notebook. The only recent change I'm aware of is the latest VSCode update to 1.78.2. I believe yesterday I was using the previous version. |
|
@karrtikr We have not release a new version of the black extension in weeks, but seems like the ability to get python paths stopped working. Can you help investigate? @FlorinAndrei what is the version of VS Code, and Python extension you have installed? did you by change update VS Code or python extension recently |
|
VSCode 1.78.2 Yeah, today I've applied the update to the latest VSCode. Now the extension is not working anymore. It was working yesterday. I cannot think of any recent meaningful change other than the VSCode update. |
|
Can you try reverting the python extension to older version? And select 2023.6.1: See if that fixes this. |
|
Success! Black Formatter v2022.6.0 works just fine. |
|
@FlorinAndrei I actually want you to revert Python extension to 2023.6.1... keep Black at 2023.2.0 |
|
Okay. Reverted Black Formatter to the latest version. Downgraded the Python extension in VSCode to version v2023.6.1 - and now Black Formatter works just fine. Re-updated the Python extension to the latest v2023.8.0 and Black Formatter still works just fine. I now have all VSCode extensions updated to the latest and the formatter is working. I cannot reproduce the issue anymore. |
|
Tested: Reverting Python extension to v2023.6.1 doesn't change the behaviour: Reverting VScode to 1.77.3 also doesn't fix for me. Reverting the Black formatter extension to The problem seems black extension to me @karthiknadig |
|
Because we have not heard back with the information we requested, we are closing this issue for now. If you are able to provide the info later on, then we will be happy to re-open this issue to pick up where we left off. Happy Coding! |
|
Because we have not heard back with the information we requested, we are closing this issue for now. If you are able to provide the info later on, then we will be happy to re-open this issue to pick up where we left off. Happy Coding! |
|
This is mitigated in the black-formatter extension. Keeping this open to get a solution in general for these scenarios. |
karthiknadig
added
bug
karrtikr
removed
the
needs spike
|
Discussing offline, but I think the right solution is to use https://github.com/microsoft/vscode-python/wiki/Python-Environment-APIs#get-current-known-environments to get all environments in the workspace and choose any one to launch LSP. What is the expectation from the API when passing |
github-actions
bot
added
the
info-needed
|
Note passing |
Summary:For multi root scenarios, when no resource is passed into
"Auto-selected workspace environment" is defined as the preferred environment in the union of environments discovered in the following scopes:
|
karrtikr
changed the title
getActiveEnvironmentPath() API when resource is passed as undefined in a multiroot workspace
karrtikr
added
area-environments
karrtikr
added
debt
Type: Bug
Behaviour
Black server doesn't start because it requires an interpreter configured, even if
"black-formatter.importStrategy": "fromEnvironment".Expected vs. Actual
It should use the environment python as interpreter if
fromEnvironmentis setup and not require the additional setting.Steps to reproduce:
Diagnostic data
python.languageServersetting: DefaultOutput for
Pythonin theOutputpanel (View→Output, change the drop-down the upper-right of theOutputpanel toPython)User Settings
{ "workbench.tree.indent": 15, "terminal.integrated.profiles.windows": { "Git Bash (Scoop)": { "path": "C:\\Users\\xxxx\\scoop\\apps\\git\\current\\bin\\bash.exe", "args": ["--login"] }, "UCRT64": { "path": "C:\\Users\\xxxx\\scoop\\apps\\msys2\\current\\usr\\bin\\bash.exe", "args": ["--login", "-i"], "env": { "MSYSTEM": "UCRT64", "CHERE_INVOKING": "1", "MSYS2_PATH_TYPE": "inherit" } }, "MINGW64": { "path": "C:\\Users\\xxxx\\scoop\\apps\\msys2\\current\\usr\\bin\\bash.exe", "args": ["--login", "-i"], "env": { "MSYSTEM": "MINGW64", "CHERE_INVOKING": "1", "MSYS2_PATH_TYPE": "inherit" } } }, "workbench.colorTheme": "Solarized Dark+", "python.defaultInterpreterPath": "C:\\Users\\xxxx\\scoop\\shims\\python3", "python.venvPath": "C:\\Users\\xxxx\\AppData\\Local\\pypoetry\\Cache\\virtualenvs", "python.formatting.provider": "none", "editor.formatOnSave": true, "isort.args": ["--profile", "black"], "[python]": { "editor.defaultFormatter": "ms-python.black-formatter", "editor.codeActionsOnSave": { "source.organizeImports": true }, "editor.formatOnType": true }, "[terraform]": { "editor.formatOnSave": true, "editor.defaultFormatter": "hashicorp.terraform", "editor.tabSize": 2 // optionally }, "python.analysis.logLevel": "Error", "terminal.integrated.defaultProfile.windows": "UCRT64", "editor.rulers": [80, 120], "vim.useSystemClipboard": true, "vim.leader": ",", "vim.foldfix": true, "vim.normalModeKeyBindings": [ { "before": ["<leader>", "r"], "commands": ["editor.action.rename"] }, { "before": ["<leader>", "R"], "commands": ["editor.action.refactor"] }, { "before": ["<leader>", "d"], "commands": ["editor.action.revealDefinition"] }, { "before": ["<leader>", "t"], "commands": ["editor.action.goToTypeDefinition"] } ], "diffEditor.ignoreTrimWhitespace": false, "editor.fontFamily": "MesloLGM NF, Consolas, 'Courier New', monospace, 'Segoe UI Emoji'", "rust-client.rustupPath": "C:\\Users\\xxxx\\scoop\\persist\\rustup\\.cargo\\bin\\rustup.exe", "security.workspace.trust.untrustedFiles": "open", "jupyter.askForKernelRestart": false, "terminal.integrated.fontFamily": "MesloLGM NF", "terminal.integrated.fontWeightBold": "bold", "editor.fontSize": 13, "explorer.confirmDelete": false, "[json]": { "editor.defaultFormatter": "esbenp.prettier-vscode" }, "vim.neovimConfigPath": "C:\\Users\\xxxx\\scoop\\shims\\nvim", "vim.enableNeovim": true, "remote.SSH.path": "C:\\Users\\xxxx\\scoop\\apps\\msys2\\current\\usr\\bin\\ssh.exe", "redhat.telemetry.enabled": true, "workbench.editorAssociations": { "git-rebase-todo": "default" }, "[javascript]": { "editor.defaultFormatter": "esbenp.prettier-vscode" }, "[yaml]": { "editor.defaultFormatter": "redhat.vscode-yaml" }, "http.proxyStrictSSL": true, "[jsonc]": { "editor.defaultFormatter": "esbenp.prettier-vscode" }, "black-formatter.importStrategy": "fromEnvironment", "black-formatter.interpreter": [ "C:\\Users\\xxxx\\scoop\\shims\\python.exe" ], "git.openRepositoryInParentFolders": "never", "window.zoomLevel": -1, "[nginx]": { "editor.defaultFormatter": "ahmadalli.vscode-nginx-conf" } }Extension version: 2023.2.0
VS Code version: Code 1.78.1 (6a995c4f4cc2ced6e3237749973982e751cb0bf9, 2023-05-04T09:48:08.683Z)
OS version: Windows_NT x64 10.0.19044
Modes:
Sandboxed: Yes
System Info
canvas_oop_rasterization: disabled_off
direct_rendering_display_compositor: disabled_off_ok
gpu_compositing: enabled
multiple_raster_threads: enabled_on
opengl: enabled_on
rasterization: enabled
raw_draw: disabled_off_ok
video_decode: enabled
video_encode: enabled
vulkan: disabled_off
webgl: enabled
webgl2: enabled
webgpu: enabled
A/B Experiments
The text was updated successfully, but these errors were encountered: