Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Activate Python Environment in Terminal created using the Extension" triggering on all terminals #20754

Closed
asportnoy opened this issue Feb 25, 2023 · 6 comments · Fixed by #20788
Closed

"Activate Python Environment in Terminal created using the Extension" triggering on all terminals #20754

asportnoy opened this issue Feb 25, 2023 · 6 comments · Fixed by #20788
Assignees
@karrtikr
Labels
area-terminal debt Covers everything internal: CI, testing, refactoring of the codebase, etc. needs PR Ready to be worked on
Milestone
March 2023

Comments

@asportnoy
Copy link

The setting above (ID python.terminal.activateEnvironment) seems to be applying to all terminals, even ones not created by the extension.
@github-actions github-actions bot added the triage-needed Needs assignment to the proper sub-team label Feb 25, 2023
@karrtikr
Copy link

That's how that setting is currently intended to work, as it is how many of our Python users expect it. Is there any issue you're having with it?

@karrtikr karrtikr added info-needed Issue requires more information from poster area-terminal labels Feb 27, 2023
@karrtikr
Copy link

Soon we'll be using #11039 to do it implicitly and stop sending commands to terminal, which may solve your issue.

@asportnoy
Copy link
Author

It sends a command to the start of each terminal which is a bit annoying. The language of the setting says it'll only apply to terminals created using the extension, so if that's not the case, the language should be updated.

@karrtikr karrtikr removed the info-needed Issue requires more information from poster label Feb 28, 2023
@karrtikr
Copy link

karrtikr commented Mar 2, 2023

Sure, we can update the language.

It sends a command to the start of each terminal which is a bit annoying.

We'll stop doing that with #11039.

@karrtikr karrtikr added debt Covers everything internal: CI, testing, refactoring of the codebase, etc. needs PR Ready to be worked on and removed triage-needed Needs assignment to the proper sub-team labels Mar 2, 2023
@karrtikr karrtikr added this to the March 2023 milestone Mar 2, 2023
@karrtikr karrtikr mentioned this issue Mar 2, 2023
Merged
@asportnoy
Copy link
Author

Thank you! ❤️

@karrtikr
Copy link

karrtikr commented Mar 2, 2023

Welcome!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@karrtikr karrtikr

Labels
area-terminal debt Covers everything internal: CI, testing, refactoring of the codebase, etc. needs PR Ready to be worked on
Projects
None yet
Milestone
March 2023
Development

Successfully merging a pull request may close this issue.

Update description of python.terminal.activateEnvironment setting karrtikr/vscode-python
2 participants
@karrtikr @asportnoy