[Code-OSS] Extension 'ms-python.python' CANNOT use API proposal: telemetryLogger

[setpill]

Type: Bug

Follow up on #20247

Trying to use the default python extension in Code OSS breaks with the following error:

Activating extension 'ms-python.python' failed: Extension 'ms-python.python' CANNOT use API proposal: telemetryLogger.
Its package.json#enabledApiProposals-property declares:  but NOT telemetryLogger.
 The missing proposal MUST be added and you must start in extension development mode or use the following command line switch: --enable-proposed-api ms-python.python.

This remains unsolved for Code OSS. Currently, a workaround exists that consists of patching product.json, but this is not a fix.

Version info:

Code OSS: 1.74.3
ms-python.python: 2022.20.1

[brettcannon]

Unfortunately the fix, beyond the workaround in the linked issue, is up to the OSS build you are using and how they choose to handle the telemetryLogger API since, from our perspective, we are using a valid API provided from VS Code itself.

[setpill]

The terminology used here is a bit unclear; what exactly do you mean with VS Code? Are you talking about https://github.com/microsoft/vscode/ ? Because the product.json in that repo does not provide the required settings out of the box. Are you saying this needs to be patched by downstream distributions for this plugin to work?

[brettcannon]

The terminology used here is a bit unclear; what exactly do you mean with VS Code? Are you talking about https://github.com/microsoft/vscode/ ?

Correct.

Because the product.json in that repo does not provide the required settings out of the box. Are you saying this needs to be patched by downstream distributions for this plugin to work?

Either that or someone submits a fix upstream. It looks like no one has opened an issue upstream to ask for any change to be made. Because most of the people who ran into issues are using a build from Arch and I know they patch their build in some ways, I'm not in a position to properly open an issue asking for some change to be made on their behalf as I don't know how much it diverges from an unmodified build from a fresh source checkout.

But I also know the telemetryLogger API should be going stable either this month or next, so if the issue is just around the API being proposed instead of stable then that will be changing shortly.

[setpill]

Ah I see, I wasn't aware it was a question of using unstable APIs. In that case I expect it to resolve itself when the API goes stable.

For sake of completeness: you are correct that in my specific case I use the Arch build, but I already checked that it wasn't an issue with them patching out some required component, and I didn't want to make this issue distribution-specific. As you can see in the product.json patch in the Arch build no lines are removed from the upstream product.json; it only adds some documentation urls, and integration with open-vsx (due to non-MS builds not being allowed to use the MS plugin marketplace).

[setpill]

FWIW it isn't the most optimal user experience that a default, official plugin uses unstable APIs that don't work unless you opt into them via some arcane patching, and that you have to manually roll back to a previous version to make it work without said patch. Perhaps this plugin could benefit from having different release channels, but that discussion is rather out of scope for this issue, just leaving my 2 cents here for your consideration :)

[albertodiazdorado]

Any solution for this in my arch machine?

Is it really the only solution to look for a different extension? 🤦‍♂️

[brettcannon]

The telemetry API went stable in VS Code 1.75 (released last week) and the latest Python extension release moved over to the stable version of that API (also released last week). If you're still having issues after updating to the newest versions of everything then I'm not sure what to suggest at this point.