Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LS Requests for dependents of Python extension. #20090

Closed
karthiknadig opened this issue Oct 27, 2022 · 2 comments
Closed

LS Requests for dependents of Python extension. #20090

karthiknadig opened this issue Oct 27, 2022 · 2 comments
Assignees
Labels
area-intellisense LSP-related functionality: auto-complete, docstrings, navigation, refactoring, etc. feature-request Request for new features or functionality needs spike Label for issues that need investigation before they can be worked on.

Comments

@karthiknadig
Copy link
Member

This is a spike to answer the question if. Do we need to handle requests/notifications from dependents of Python extension.

@karthiknadig karthiknadig added the feature-request Request for new features or functionality label Oct 27, 2022
@github-actions github-actions bot added the triage-needed Needs assignment to the proper sub-team label Oct 27, 2022
@karthiknadig karthiknadig added area-intellisense LSP-related functionality: auto-complete, docstrings, navigation, refactoring, etc. needs spike Label for issues that need investigation before they can be worked on. and removed triage-needed Needs assignment to the proper sub-team labels Oct 27, 2022
@karthiknadig karthiknadig self-assigned this Oct 27, 2022
@karthiknadig
Copy link
Member Author

There is no getting around exposing the languageClient to Jupyter. Based on investigations done here and for #19129 .

So, we will need to expose an API that provides the client. The client object provided by python extension will have to keep in sync with actual language client. Since process (LS server process and actual LS client object) lifetime management may have to be done by LS provider extensions ( Pylance), there are few things, such as client.start(), client.stop() have to be wrapped by the client object provided by the python extension.

@karthiknadig
Copy link
Member Author

A thing to note about server and client creation. An issue with the current model is that initialization options for servers are not provided by jupyter. See trustedWorkspaceSupport for Pylance or disableSnippets for Jedi.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-intellisense LSP-related functionality: auto-complete, docstrings, navigation, refactoring, etc. feature-request Request for new features or functionality needs spike Label for issues that need investigation before they can be worked on.
Projects
None yet
Development

No branches or pull requests

1 participant