Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stabilize environment extension API #19989

Closed
karrtikr opened this issue Oct 11, 2022 · 9 comments · Fixed by #20868
Closed

Stabilize environment extension API #19989

karrtikr opened this issue Oct 11, 2022 · 9 comments · Fixed by #20868
Assignees
Labels
area-environments Features relating to handling interpreter environments feature-request Request for new features or functionality needs proposal Need to make some design decisions verification-needed Verification of issue is requested verified Verification succeeded
Milestone

Comments

@karrtikr
Copy link

Currently blocked on Jupyter feedback: microsoft/vscode-jupyter#7583.

General feedback issue: #18888

@karrtikr karrtikr added feature-request Request for new features or functionality needs proposal Need to make some design decisions area-environments Features relating to handling interpreter environments labels Oct 11, 2022
@karrtikr karrtikr added this to the October 2022 milestone Oct 11, 2022
@karrtikr karrtikr self-assigned this Oct 11, 2022
@karrtikr
Copy link
Author

Waiting on microsoft/vscode-jupyter#7583 (comment) to decide whether to finalize this in the next iteration.

@karrtikr karrtikr modified the milestones: October 2022, November 2022 Oct 24, 2022
@karrtikr
Copy link
Author

Make sure to also finalize #20056 along with this issue, and deprecate existing related stable APIs.

@karrtikr
Copy link
Author

List of all issues: #20240.

@karrtikr
Copy link
Author

karrtikr commented Mar 7, 2023

@DonJayamanne As things look good with Jupyter we plan to finalize this API in this iteration, just an FYI.

@DonJayamanne
Copy link

DonJayamanne commented Mar 7, 2023

FYI - Its possible (depends on the solution/change) there could be some API changes as a result of this #20765

@karrtikr karrtikr added the verification-needed Verification of issue is requested label Mar 17, 2023
@karrtikr
Copy link
Author

Verification steps:

See https://github.com/microsoft/vscode-python/wiki/Python-Environment-APIs#extension-api-usage for usage examples, choose any one example and ensure API still works.

@DonJayamanne DonJayamanne added the verified Verification succeeded label Mar 22, 2023
@DonJayamanne
Copy link

DonJayamanne commented Mar 22, 2023

Works well, as expected.

@karrtikr Should we have a sample extension for this, else verification is time consuming, and any changes made would require repeating the same time consuming effort

@karrtikr
Copy link
Author

karrtikr commented Mar 22, 2023

Sounds reasonable, will add it in the example wiki sent earlier.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-environments Features relating to handling interpreter environments feature-request Request for new features or functionality needs proposal Need to make some design decisions verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants